fix(useScrollspy): unobserve previous headings on update - #261
Merged
Conversation
observerCallback now batches all entry changes into a Set and writes visibleHeadings once per callback (not once per entry), and updateHeadings disconnects the observer and resets visibleHeadings before re-observing so repeated calls (e.g. page navigation) don't accumulate stale targets. Adds the upstream useScrollspy composable spec. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs upstream nuxt/ui commit
5944067— fix(useScrollspy): unobserve previous headings on update (#6700).What
Two fixes to the
useScrollspycomposable:observerCallbackcollects all intersection-entry changes into aSetand writesvisibleHeadingsonce per callback (guarded by achangedflag) instead of once per entry, so the watcher fires a single time per IntersectionObserver callback.updateHeadingsnowdisconnect()s the observer and resetsvisibleHeadingsbefore re-observing, so repeated calls (e.g. page navigation) don't accumulate stale observed targets.b24ui's composable matched upstream exactly, so both rewrites applied verbatim. Added the upstream
test/composables/useScrollspy.spec.ts(composable-only, with a mockIntersectionObserver; import paths identical in b24ui) — covering observe/track/remove, the retained-highlight behaviour, the stop-observing-on-update regression, and id-less entries.Verify (
CI=true)dev:prepare·lint·typecheck·test·build— all green. Suite 5355 passed / 6 skipped (+2 test files, 229→231). No snapshot changes.Ledger: cursor advanced to
5944067; previous entry000aba4reconciled to PR #260.🤖 Generated with Claude Code
Generated by Claude Code