chore(deps): upgrade @pkcprotocol/pkc-js 0.0.81 -> 0.0.82 - #127
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR updates the ChangesPKC dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This dependency-only upgrade has passed the reported build and CLI checks, and no actionable merge-blocking risk remains beyond normal review and verification. Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #126
What
Bumps
@pkcprotocol/pkc-jsfrom0.0.81to0.0.82(latest). Dependency-only change — no source edits.Upstream changes
v0.0.82
Features
comment.crosspost(feat(crosspost): embed the reposted comment in comment.crosspost (#32) pkcprotocol/pkc-js#248, closes implement crosspost pkcprotocol/pkc-js#32) — a crossposting comment now carries the fullCommentIpfsof the comment it reposts, so the crossposting community's mods can moderate it in place. Adds anoCrosspostscommunity feature.Bug Fixes
destroy()and drain their background community refresh (fix(pkc): stop in-flight publications in destroy() and drain their background community refresh pkcprotocol/pkc-js#271, closes fix(pkc): stop in-flight publications in pkc.destroy() pkcprotocol/pkc-js#270)Neither needs CLI plumbing here: community features are passed through generically rather than enumerated in
src/, sonoCrosspostsis reachable without changes.Verification
npm run build && npm run build:test— cleannpm run test:cli— 43 files, 333 passed, 6 skippedOne file (
test/cli/daemon.test.ts) hit a pre-existing flake on the first full run; it passes on re-run (23/23) and is unrelated to this bump. Details below.Follow-up worth a look (not changed here)
test/helpers/daemon-helpers.tsretries the TOCTOU port race viaisAddressInUseError, which matches three signatures:There is a fourth wording it does not cover.
src/ipfs/startIpfs.ts:215raises the CLI's own pre-bind guard as:That string contains
is already in usebut notaddress already in use, so the matcher returns false,startPkcDaemonWithDynamicPortsrethrows instead of retrying with a fresh port set, and the suite'sbeforeAlldies. Same root cause as issues #87 / #97, just a third message wording — the gateway port, where the earlier fixes covered the raw bind failure and the PKC RPC pre-bind guard.A second, avoidable failure lands on top:
afterAllstill runs and callswaitForPortFree(rpcPort, ...)withrpcPortnever assigned, so alongside the real startup error the run also reportswhich points at the teardown rather than the lost bind race. Both errors are reported, so the cause is not hidden outright, but the spurious one is the eye-catching part.
Tracked and fixed separately in #128 — this PR stays dependency-only.