chore(deps): upgrade @pkcprotocol/pkc-js 0.0.85 -> 0.0.89 - #139
Conversation
Notable upstream changes: helia upgraded to v7 with the libp2p/ipfs ecosystem deps (0.0.89), statsCid made optional on CommunityIpfsSchema (0.0.88), gossipsub 17 with a per-peer topic memory bound whose default is well clear of our topologies (0.0.87), and community key migration announced to late joiners (0.0.86). No CLI code changes needed; full test suite passes. Claude-Session: https://claude.ai/code/session_01LLoQA6LHpw8giF4hnZ3R4P
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates ChangesPKC dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR upgrades the PKC dependency and updates its lockfile without identified correctness, availability, security, or deployment issues. Build and CLI tests pass, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
) A command hang in CI previously produced no information at all: the vitest per-test timeout (10s) raced the subprocess timeout (also 10s) and won, replacing the informative rejection - which carries the child's stdout/stderr - with a generic "Test timed out in 10000ms". The daemon's logs also lived in a temp dir CI never surfaces. - Raise vitest per-test timeouts above the subprocess timeouts so the informative rejection always wins; the 10s/30s completion-time enforcement itself is unchanged (the subprocess timeout still kills and fails the command at the same thresholds). - On timeout, collect daemon-side diagnostics: the daemon's captured stdout/stderr and the tail of each log file in its --logPath dir, capped at 8KB per section. - Guard the close handler with a timedOut flag: after SIGKILL the child's close event fired while diagnostics collection was awaited, resolving the promise with exitCode null and losing the rejection. Claude-Session: https://claude.ai/code/session_01NbSJp6rKMc151AV2eujzmj
|
Pushed a second commit addressing the Windows CI timeout from the first run (see #140): The new commit keeps the 10s/30s completion-time enforcement in the subprocess timeout (unchanged thresholds) but raises the vitest timeouts so the informative rejection — child stdout/stderr plus daemon captured output and daemon log file tails, capped at 8KB per section — is what CI prints if a command hangs again. For the failure itself: on the same run the test took 0.9s on ubuntu and 1.5s on macos, and the last green master windows run did it in 1.7s, so it looks like a one-off Windows hang rather than a pkc-js 0.0.89 regression. If it recurs, CI will now show where it got stuck. |
chore(deps): upgrade @pkcprotocol/pkc-js 0.0.85 -> 0.0.89
1 participant
Summary
Upgrades
@pkcprotocol/pkc-jsfrom 0.0.85 to 0.0.89 (latest).Notable upstream changes:
statsCidmade optional onCommunityIpfsSchema(fix(community): make statsCid optional on CommunityIpfsSchema pkcprotocol/pkc-js#298)maxTopicBytesPerPeerdefault (1 MiB ≈ 1000 topics per peer), well clear of the topologies we run; also awaits source db removal indelete()and scopes the started-community registry by dataPathupdate()survives after a migrationNo CLI code changes were needed.
Testing
npm run build && npm run build:testpassnpm run test:cli: 43 files, 341 tests passed, 1 skippedSummary by CodeRabbit