Add UWP support#139
Conversation
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "UWP", "src\UWP\UWP.csproj", "{3A2D5669-ED71-4F2B-BA85-2D36BAA05141}" | ||
| EndProject | ||
| Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "UWP.Images", "src\UWP.Images\UWP.Images.shproj", "{0BE54BBB-7772-4289-BD51-1FDBB0CC2446}" |
There was a problem hiding this comment.
Does this really have to be a whole separate project?
There was a problem hiding this comment.
Images have to be on root folder in UWP, which is not perfect for files organization.
Which is why I put them in a separate shared project.
Do you have a better idea?
| }; | ||
|
|
||
| if(Device != null) | ||
| if(false && Device != null) |
There was a problem hiding this comment.
Yes, I was testing the connection and I forgot it
I will correct it
| <Import_RootNamespace>UWP.Images</Import_RootNamespace> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Content Include="$(MSBuildThisFileDirectory)camera.png" /> |
There was a problem hiding this comment.
How are 2x, 3x, etc handled in UWP?
There was a problem hiding this comment.
these are the guidelines for images scaling: https://msdn.microsoft.com/library/windows/apps/xaml/hh965325?f=255&MSPPError=-2147217396
but the other resolutions can be added after having a read to publish app, if you are OK?
| sealed partial class App : Application | ||
| { | ||
|
|
||
| public ISettings Settings { get; set; } |
| private const int KeyLength = 256; // 32 bytes | ||
|
|
||
| //todo review this | ||
| public byte[] DeriveKey(byte[] password, byte[] salt, uint rounds) |
There was a problem hiding this comment.
Seems fine since you are using the same BC implementation as Android. I know .NET Core has a native implementation for PBKDF2 so maybe we can switch to that when we move to .NET standard.
There was a problem hiding this comment.
I didn't know about native implementation of PBKDF2, I added it now
| { | ||
| public class SecureStorageService : ISecureStorageService | ||
| { | ||
| private string resourceName = "BitWarden"; |
| public class SecureStorageService : ISecureStorageService | ||
| { | ||
| private string resourceName = "BitWarden"; | ||
| private PasswordVault _vault = new PasswordVault(); |
|
I just added two commits, adding IDeviceActionService implementation, and fixing an issue with HasCamera property. |
|
Thanks for this again. I have merged it in. I updated the code with a few commits to fix formatting issues and code style to match the rest of the project. Feel free to continue additional PRs as needed. I will revisit this at some point myself as well. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2 participants
Hi, this is the first PR for UWP support, the application can compile and run (tested on a laptop with Windows CU).
The main changes to the PCL project:
The interfaces IGoogleAnalyticsService and IDeviceActionService are still not implemented.
And the application still uses the default theme which needs some tweaking.
#9