[SG-416] Updates to Bitwarden Authenticator (Feature Branch)#2041
Merged
andrebispo5 merged 62 commits intomasterfrom Aug 17, 2022
Merged
[SG-416] Updates to Bitwarden Authenticator (Feature Branch)#2041andrebispo5 merged 62 commits intomasterfrom
andrebispo5 merged 62 commits intomasterfrom
Conversation
This reverts commit b02c58e.
# Conflicts: # src/App/App.csproj
# Conflicts: # src/App/Pages/Authenticator/AuthenticatorPage.xaml # src/App/Pages/Authenticator/AuthenticatorPage.xaml.cs # src/App/Pages/Authenticator/AuthenticatorPageViewModel.cs
… details, Added new text resource
…ored circular progress view.
…y text of switch because android was overlapping text.
…en. Changed existing labels on scanner screen.
…Added scan success animation.
# Conflicts: # src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs # src/App/Pages/Vault/ScanPage.xaml.cs
… subscription required.
# Conflicts: # src/App/Resources/AppResources.Designer.cs # src/App/Resources/AppResources.resx
… it places an helper text next to the switch making it invisible. Also removed from the label because it already reads the text from the label
# Conflicts: # src/App/Resources/AppResources.Designer.cs # src/App/Resources/AppResources.resx
This reverts commit 2f2b90a.
# Conflicts: # src/Android/Properties/AndroidManifest.xml # src/App/Pages/Vault/CipherAddEditPageViewModel.cs # src/App/Pages/Vault/CipherDetailsPage.xaml.cs # src/App/Pages/Vault/CipherDetailsPageViewModel.cs # src/App/Resources/AppResources.Designer.cs
* [SG-416] Removed toggle to TOTP. Added on MainPage new entry to go to screen with TOTP codes. Added filter for TOTP codes to be used when searching. * [SG-416] Removed unnecessary code. Added nav back if there is only 1 cipher with totp code and the user removes it. * [SG-416] Run dotnet format tool * [SG-416] PR fixes * [SG-416] PR Fixes. Manifest formatting. Add try catch. Extracted method and added null protection. * [SG-416] Make TOTP codes appear above favourites. * [SG-416] PR fixes. Show error dialog.
andrebispo5
changed the title
fedemkr
approved these changes
Aug 17, 2022
Member
fedemkr
left a comment
fedemkr
left a comment
There was a problem hiding this comment.
Already reviewed on the PRs made to feature/feature-totp so approving this directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Feature branch containing all reviewed PRs from the updates to Bitwarden authenticator:
bitwarden/mobile#1964
bitwarden/mobile#2027
Before you submit
dotnet tool run dotnet-format --check) (required)