Skip to content

Pages: Settings: Disable fingerprint on Windows#206

Closed
alistair23 wants to merge 1 commit intobitwarden:masterfrom
alistair23:alistair/fingerprint
Closed

Pages: Settings: Disable fingerprint on Windows#206
alistair23 wants to merge 1 commit intobitwarden:masterfrom
alistair23:alistair/fingerprint

Conversation

@alistair23
Copy link

Looking at the documentation here:
https://github.com/smstuebe/xamarin-fingerprint/blob/master/README.md
the GetAvailabilityAsync() and IsAvailableAsync() don't work on Windows.
To avoid always seeing the fingerprint option just diable it on Windows
as at the moment it's untested.

Signed-off-by: Alistair Francis alistair@alistair23.me

Looking at the documentation here:
https://github.com/smstuebe/xamarin-fingerprint/blob/master/README.md
the GetAvailabilityAsync() and IsAvailableAsync() don't work on Windows.
To avoid always seeing the fingerprint option just diable it on Windows
as at the moment it's untested.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
@kspearrin
Copy link
Member

Where on the Fingerprint plugin page do you see that it doesn't work with Windows?

@alistair23
Copy link
Author

alistair23 commented Dec 13, 2017

The problem is that I always see the option. I see it on my Surface Pro 2 and Windows Phone, both of which don't have fingerprint sensors.

PS: The not available information is in the API description, where the functions are described.

@alistair23
Copy link
Author

Ah! So if I turn fingerprint login on then I can use Windows Hello to login. On my surface it asks for my account pin and on my phone it uses the Iris scanner.

So we just need to change some of the pharses to say "Windows Hello" instead of fingerprint.

@alistair23 alistair23 closed this Dec 13, 2017
@alistair23
Copy link
Author

How do you generate all of the translations? Does something like "Windows Hello" (https://support.microsoft.com/en-us/help/17215/windows-10-what-is-hello) need a translation?

@kspearrin
Copy link
Member

We likely just need to add the options to show a different string much like we already do for Fingerprint vs TouchID vs FaceID.

@alistair23
Copy link
Author

Ok, that looks to be pretty easy. Good forward thinking there

UCan927 pushed a commit to UCan927/BitWarden-Android that referenced this pull request Jun 22, 2024
vvolkgang pushed a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants