Pages: Settings: Disable fingerprint on Windows#206
Pages: Settings: Disable fingerprint on Windows#206alistair23 wants to merge 1 commit intobitwarden:masterfrom
Conversation
Looking at the documentation here: https://github.com/smstuebe/xamarin-fingerprint/blob/master/README.md the GetAvailabilityAsync() and IsAvailableAsync() don't work on Windows. To avoid always seeing the fingerprint option just diable it on Windows as at the moment it's untested. Signed-off-by: Alistair Francis <alistair@alistair23.me>
|
Where on the Fingerprint plugin page do you see that it doesn't work with Windows? |
|
The problem is that I always see the option. I see it on my Surface Pro 2 and Windows Phone, both of which don't have fingerprint sensors. PS: The not available information is in the API description, where the functions are described. |
|
Ah! So if I turn fingerprint login on then I can use Windows Hello to login. On my surface it asks for my account pin and on my phone it uses the Iris scanner. So we just need to change some of the pharses to say "Windows Hello" instead of fingerprint. |
|
How do you generate all of the translations? Does something like "Windows Hello" (https://support.microsoft.com/en-us/help/17215/windows-10-what-is-hello) need a translation? |
|
We likely just need to add the options to show a different string much like we already do for Fingerprint vs TouchID vs FaceID. |
|
Ok, that looks to be pretty easy. Good forward thinking there |
Looking at the documentation here:
https://github.com/smstuebe/xamarin-fingerprint/blob/master/README.md
the GetAvailabilityAsync() and IsAvailableAsync() don't work on Windows.
To avoid always seeing the fingerprint option just diable it on Windows
as at the moment it's untested.
Signed-off-by: Alistair Francis alistair@alistair23.me