Skip to content

[SG-1052] [Defect] - Log in with device button case incorrect#2353

Merged
trmartin4 merged 1 commit intomasterfrom
bugfix/SG-1052-fix-copy
Feb 9, 2023
Merged

[SG-1052] [Defect] - Log in with device button case incorrect#2353
trmartin4 merged 1 commit intomasterfrom
bugfix/SG-1052-fix-copy

Conversation

@andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The ‘Log in with device’ button option currently reads ‘Log In with device’

  • The 'i' should not be capitalized
  • it should be displayed as, ‘Log in with device’

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested review from a team February 9, 2023 19:53
Copy link

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@trmartin4 trmartin4 merged commit 0bd1b3f into master Feb 9, 2023
@trmartin4 trmartin4 deleted the bugfix/SG-1052-fix-copy branch February 9, 2023 20:13
trmartin4 pushed a commit that referenced this pull request Feb 9, 2023
(cherry picked from commit 0bd1b3f)
Eeebru added a commit that referenced this pull request Feb 15, 2023
* [SG-1057] Make check breaches true by default (#2351)

(cherry picked from commit 6875389)

* [SG-1055] Init strength bar color (#2352)

(cherry picked from commit 3780587)

* [SG-1052] Fix copy (#2353)

(cherry picked from commit 0bd1b3f)

* [SG-1056] Fix login prompt loop for added accounts (#2357)

* SG-1056 Fix login prompt loop for added accounts

* SG-1056 Fix PR comment

(cherry picked from commit f42c677)

* Bumped version to 2023.2.0

---------

Co-authored-by: André Bispo <abispo@bitwarden.com>
Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com>
Eeebru added a commit that referenced this pull request Feb 15, 2023
* [SG-1057] Make check breaches true by default (#2351)

(cherry picked from commit 6875389)

* [SG-1055] Init strength bar color (#2352)

(cherry picked from commit 3780587)

* [SG-1052] Fix copy (#2353)

(cherry picked from commit 0bd1b3f)

* [SG-1056] Fix login prompt loop for added accounts (#2357)

* SG-1056 Fix login prompt loop for added accounts

* SG-1056 Fix PR comment

(cherry picked from commit f42c677)

* Bumped version to 2023.2.0

---------

Co-authored-by: André Bispo <abispo@bitwarden.com>
Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com>
(cherry picked from commit bc439b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants