[SG-1056] Fix login prompt loop for added accounts#2357
Merged
LRNcardozoWDF merged 2 commits intomasterfrom Feb 10, 2023
Merged
[SG-1056] Fix login prompt loop for added accounts#2357LRNcardozoWDF merged 2 commits intomasterfrom
LRNcardozoWDF merged 2 commits intomasterfrom
Conversation
mpbw2
reviewed
Feb 10, 2023
| (await _stateService.GetEnvironmentUrlsAsync(userId))?.Base == _environmentService.BaseUrl && | ||
| await _stateService.IsAuthenticatedAsync(userId)) | ||
| { | ||
| await _accountManager.PromptToSwitchToExistingAccountAsync(userId); |
Contributor
There was a problem hiding this comment.
Looks good, but per existing patterns leave the return here and keep StartLoginAction() outside like before
mpbw2
approved these changes
Feb 10, 2023
LRNcardozoWDF
deleted the
bug/SG-1056-Fix-prompt-account-already-added-loop
branch
trmartin4
pushed a commit
that referenced
this pull request
Feb 10, 2023
* SG-1056 Fix login prompt loop for added accounts * SG-1056 Fix PR comment (cherry picked from commit f42c677)
Eeebru
added a commit
that referenced
this pull request
Feb 15, 2023
* [SG-1057] Make check breaches true by default (#2351) (cherry picked from commit 6875389) * [SG-1055] Init strength bar color (#2352) (cherry picked from commit 3780587) * [SG-1052] Fix copy (#2353) (cherry picked from commit 0bd1b3f) * [SG-1056] Fix login prompt loop for added accounts (#2357) * SG-1056 Fix login prompt loop for added accounts * SG-1056 Fix PR comment (cherry picked from commit f42c677) * Bumped version to 2023.2.0 --------- Co-authored-by: André Bispo <abispo@bitwarden.com> Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com> Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> Co-authored-by: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com>
Eeebru
added a commit
that referenced
this pull request
Feb 15, 2023
* [SG-1057] Make check breaches true by default (#2351) (cherry picked from commit 6875389) * [SG-1055] Init strength bar color (#2352) (cherry picked from commit 3780587) * [SG-1052] Fix copy (#2353) (cherry picked from commit 0bd1b3f) * [SG-1056] Fix login prompt loop for added accounts (#2357) * SG-1056 Fix login prompt loop for added accounts * SG-1056 Fix PR comment (cherry picked from commit f42c677) * Bumped version to 2023.2.0 --------- Co-authored-by: André Bispo <abispo@bitwarden.com> Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com> Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> Co-authored-by: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com> (cherry picked from commit bc439b4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix ‘Account already added Would you like to switch to it now?’ prompt loop when performing login with an account already added.
Code changes
Before you submit
dotnet format --verify-no-changes) (required)