[PM-1133] OTP Handling - Update empty states#2408
Merged
fedemkr merged 2 commits intofeature/EC-979-iOS-third-party-2fafrom Mar 8, 2023
Merged
Conversation
…ird-party-2fa/PM-1133-update-empty-states
mpbw2
approved these changes
Mar 8, 2023
fedemkr
deleted the
feature/ios-third-party-2fa/PM-1133-update-empty-states
branch
5 tasks
fedemkr
added a commit
that referenced
this pull request
Mar 9, 2023
* [EC-980] Added iOS otpauth handler (#2370) * EC-980 added Bitwarden as otpauth scheme handler * EC-980 Fix format * [EC-981] OTP handling - Set to selected cipher (#2404) * EC-981 Started adding OTP to existing cipher. Reused AutofillCiphersPage for the cipher selection and refactored it so that we have more code reuse * EC-981 Fix navigation on otp handling * EC-981 Fix formatting * EC-981 Added otp cipher selection callout and add close toolbar item when needed * PM-1131 implemented cipher creation from otp handling flow with otp key filled (#2407) * PM-1133 Updated empty states for search and cipher selection on otp flow (#2408)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Update empty states when selecting a cipher on the OTP handling flow and on the search.
Code changes
ShowAddCipherto check when to display the add buttonScreenshots
Cipher selection OTP Flow empty
Cipher selection OTP Flow empty dark
Seach empty
Note: I put the whole layout more to the top instead of fully centered because I wanted all the info to be seen with the keyboard opened.
Search empty dark
Before you submit
dotnet format --verify-no-changes) (required)