Conversation
…overable passkey inside of a cipher login
mpbw2
previously approved these changes
May 25, 2023
mpbw2
previously approved these changes
Jun 13, 2023
…hen moving a cipher to an org" This reverts commit 78e6353.
# Conflicts: # src/App/Resources/AppResources.Designer.cs
|
New Issues
|
… to an organization (#2594) * PM-2378 Display error toast if there is a duplicate passkey when moving a cipher to an org * PM-3097 Fix issue when moving cipher with passkey to an org where the uniqueness should be taken into consideration on different passkeys types and also the Username (#2632) * PM-3096 Fix non-discoverable passkey to be taken into account when encrypting a cipher which was causing the passkey to be removed when moving to an org (#2637)
mpbw2
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Display Discoverable and Non-Discoverable Passkeys.
Code changes
Fido2KeyCreationDatestring builtFido2KeyfromLoginwhen cloning and added bool to show/hide non-discoverable passkey if in clone mode.Clonefrom the toolbar for Passkeys types. Moved Clone logic to ViewModel.ILaunchableViewto launch either aLoginor aPasskey/Fido2Key. AddedCloneCommandand moved clone logic here also adding when a cipher can be cloned, particularly on logins with non-discoverable passkey, the user needs to decide whether to clone it or not after warning them that the passkey won't be cloned.Fido2Keyname and iconFido2Keyto be taken into account when filtering byLogingiven that they should be displayed side by side.MoveCommandto be more specific.Fido2Keylogic and move things a little to be more reusableFido2Key. Also addedComparableNameso we avoid type checking and it's more direct and in place. Additionally, added theILaunchableViewinterface so that the caller doesn't need to know the inner types to get whether it can be launched or which is the launch uri.Fido2Keynew logic.Screenshots
Before you submit
dotnet format --verify-no-changes) (required)