[PM-2378] Display error toast on duplicate Passkey when moving cipher to an organization#2594
Merged
fedemkr merged 4 commits intoPM-1575-display-passkeysfrom Jul 24, 2023
Conversation
…ng a cipher to an org
fedemkr
changed the title
mpbw2
approved these changes
Jun 29, 2023
Contributor
mpbw2
left a comment
mpbw2
left a comment
There was a problem hiding this comment.
ThisItemCannotBeSharedWithTheOrganizationBecauseThereIsOneAlreadyWithTheSamePasskey
perfect
mpbw2
reviewed
Jul 21, 2023
| </data> | ||
| <data name="EnterURI" xml:space="preserve"> | ||
| <value>Enter URI</value> | ||
| </data> |
Contributor
There was a problem hiding this comment.
URISaved is already declared above (line 2683)
mpbw2
approved these changes
Jul 21, 2023
fedemkr
deleted the
PM-2378-handle-duplicate-passkey-on-moving-item-to-org
branch
fedemkr
added a commit
that referenced
this pull request
Jul 26, 2023
* PM-1575 Added new models for Fido2Key * PM-1575 Added discoverable passkeys and WIP non-discoverable ones * PM-1575 Fix format * PM-1575 Added non-discoverable passkeys to login UI * PM-1575 Added copy application icon to Fido2Key UI * PM-1575 Updated bwi font with the updated passkey icon * PM-1575 For now just display Available for two-step login on non-discoverable passkey inside of a cipher login * PM-1575 Fix non-discoverable passkey visibility * PM-1575 remove Passkeys as a filter in the vault list * PM-1575 Display error toast if there is a duplicate passkey when moving a cipher to an org * Revert "PM-1575 Display error toast if there is a duplicate passkey when moving a cipher to an org" This reverts commit 78e6353. * [PM-2378] Display error toast on duplicate Passkey when moving cipher to an organization (#2594) * PM-2378 Display error toast if there is a duplicate passkey when moving a cipher to an org * PM-3097 Fix issue when moving cipher with passkey to an org where the uniqueness should be taken into consideration on different passkeys types and also the Username (#2632) * PM-3096 Fix non-discoverable passkey to be taken into account when encrypting a cipher which was causing the passkey to be removed when moving to an org (#2637)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Display error toast on duplicate passkey when moving item to an organization.
Code changes
ShareWithServerErrorto return the appropriate response to the caller when sharing cipher to an org. I cannot throw anApiExceptionwith the error inside given thatAppResourcesis not available in theCoreproject. Also another way would be to create and throw a specific exception for this and handle it on the caller but I thought this was better and the caller can handle the different paths more directly.RpId(duplicate passkey) to return an error if that's the case.Before you submit
dotnet format --verify-no-changes) (required)