[PM-37255] feat: Wire fill-assist manager into vault sync and app startup

[aj-rosado]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37255

📔 Objective

Connects the fill-assist manager to the rest of the app so rules are fetched and kept fresh automatically.

Changes:

• VaultSyncManagerImpl — calls fillAssistManager.syncIfNecessary() after vault data is stored; fill-assist failures are silently dropped and never affect vault sync
• VaultManagerModule — injects FillAssistManager into VaultSyncManager
• BitwardenApplication — injects FillAssistManager to trigger eager initialization; the init {} block subscribes to serverConfigStateFlow for config-change-triggered syncs

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the wiring of FillAssistManager into vault sync and app startup. Changes inject the manager into VaultSyncManagerImpl (triggering syncIfNecessary() after vault data is stored), register it in VaultManagerModule, and eagerly initialize it via BitwardenApplication. The fill-assist sync runs fire-and-forget on a separate ioScope, so failures cannot affect vault sync as described. Test coverage appropriately verifies the call happens on success paths and is skipped on the security-stamp-mismatch early-return path, addressing the prior reviewer request.

Code Review Details

No blocking findings.

Notes considered and intentionally not flagged:

• The early-return "skip sync" path (no server changes) does not call syncIfNecessary(), but this is self-correcting via the serverConfigStateFlow subscription in FillAssistManagerImpl.init {} and the internal 6-hour interval check — appears intentional.
• New imports in VaultSyncManagerImpl.kt and VaultManagerModule.kt are slightly out of alphabetical order; ktlint/detekt will catch this in CI.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.19%. Comparing base (61db0cd) to head (b718f56).

Additional details and impacted files

@@                         Coverage Diff                          @@
##           PM-37255/fill-assist-data-layer    #6992       +/-   ##
====================================================================
+ Coverage                            69.18%   86.19%   +17.00%     
====================================================================
  Files                                  878      878               
  Lines                                63557    64003      +446     
  Branches                              9245     9272       +27     
====================================================================
+ Hits                                 43974    55168    +11194     
+ Misses                               16792     5636    -11156     
- Partials                              2791     3199      +408     

Flag	Coverage Δ
app-data	17.37% <100.00%> (+<0.01%)	⬆️
app-ui-auth-tools	18.98% <0.00%> (?)
app-ui-platform	16.45% <0.00%> (-0.01%)	⬇️
app-ui-vault	27.75% <0.00%> (-0.01%)	⬇️
authenticator	6.20% <0.00%> (+<0.01%)	⬆️
lib-core-network-bridge	4.10% <0.00%> (+<0.01%)	⬆️
lib-data-ui	1.14% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[david-livefront]

Can you make sure the appropriate verify calls happen