[PM-39461] bug: Fix QR scan reliability by using Y plane rowStride in analyzer#7097
Merged
david-livefront merged 1 commit intoJun 26, 2026
Merged
Conversation
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
Closed
1 task
david-livefront
changed the title
david-livefront
approved these changes
Jun 26, 2026
Collaborator
|
Thanks for your contributions @koenyskout |
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #6264
QR codes did not scan on some phones. Inspired by Redth/ZXing.Net.Maui#202, I tried using plane.rowStride instead of image.width for the dataWidth parameter of PlanarYUVLuminanceSource. This fixed the issue on my Motorola G9 Power and G9 Plus; both can now successfully scan QR codes in the Authenticator app. I have no other devices (that didn't have the scanning problem before) to test.