Skip to content

PM-39707: feat: Display unique unpaid subscription UI#7117

Merged
david-livefront merged 1 commit into
mainfrom
PM-39707-unpaid-status
Jun 30, 2026
Merged

PM-39707: feat: Display unique unpaid subscription UI#7117
david-livefront merged 1 commit into
mainfrom
PM-39707-unpaid-status

Conversation

@david-livefront

@david-livefront david-livefront commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-39707

📔 Objective

This PR adds a unique UI for the Unpaid subscription state and addresses some minor UI discrepancies.

📸 Screenshots

Before After

@david-livefront
david-livefront requested a review from a team as a code owner June 29, 2026 19:24
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jun 29, 2026
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of a dedicated Unpaid premium subscription state and the accompanying UI refinements on the Plan screen. The new UNPAID enum value is handled exhaustively across every when over PremiumSubscriptionStatus (badge colors, feature-list visibility, cancel eligibility, premium-view eligibility, description text, and the premium card state), and the JSON mapping correctly splits UNPAID out of the former UPDATE_PAYMENT bucket. Theme additions (labelLargeEmphasis typography, badge shape) are additive with single construction sites, and the test changes align with the behavioral change.

No blocking findings.

Code Review Details

No findings. The change is well-scoped:

  • UNPAID follows the existing suspensionDateText ?: PLACEHOLDER_TEXT fallback pattern used by UPDATE_PAYMENT and PAST_DUE.
  • All enum when branches remain exhaustive (compile-time enforced), so no status is silently unhandled.
  • The split of toSubscriptionInfo maps UNPAID to UNPAID from the old combined test correctly reflects the new mapping.

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront
david-livefront added this pull request to the merge queue Jun 30, 2026
Merged via the queue into main with commit d468197 Jun 30, 2026
24 of 26 checks passed
@david-livefront
david-livefront deleted the PM-39707-unpaid-status branch June 30, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants