Skip to content

PM-40651: feat: Add feature flag for FedRAMP#7136

Merged
david-livefront merged 1 commit into
mainfrom
fed-ramp-feature-flag
Jul 2, 2026
Merged

PM-40651: feat: Add feature flag for FedRAMP#7136
david-livefront merged 1 commit into
mainfrom
fed-ramp-feature-flag

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-40651

📔 Objective

This PR adds a feature flag for FedRAMP, the flag does not do anything at this time.

@david-livefront
david-livefront requested a review from a team as a code owner July 2, 2026 17:35
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a new FedRamp boolean feature flag (fedramp-gov-region, default false) that is currently a no-op. The change follows the established FlagKey pattern precisely: the flag is registered in activePasswordManagerFlags, wired into both when branches in FeatureFlagListItems.kt (preserving exhaustiveness), given a non-localized debug-menu string, and covered by updates to both existing tests. No security, correctness, or breaking-change concerns identified.

Code Review Details

No blocking findings.

Minor (non-blocking): the KDoc for FedRamp reads "theFedRAMP feature" (missing space) in core/src/main/kotlin/com/bitwarden/core/data/manager/model/FlagKey.kt:175. Cosmetic only.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.75%. Comparing base (974006a) to head (c5d2b2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7136      +/-   ##
==========================================
+ Coverage   86.17%   86.75%   +0.58%     
==========================================
  Files         882      868      -14     
  Lines       64344    63913     -431     
  Branches     9580     9577       -3     
==========================================
  Hits        55449    55449              
+ Misses       5451     5020     -431     
  Partials     3444     3444              
Flag Coverage Δ
app-data 17.58% <ø> (ø)
app-ui-auth-tools 18.76% <ø> (ø)
app-ui-platform 16.49% <ø> (ø)
app-ui-vault 27.52% <ø> (ø)
authenticator 6.18% <ø> (+0.04%) ⬆️
lib-core-network-bridge 4.06% <ø> (+0.02%) ⬆️
lib-data-ui 1.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}

/**
* Data object holding the feature flag key for theFedRAMP feature.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️

Suggested change
* Data object holding the feature flag key for theFedRAMP feature.
* Data object holding the feature flag key for the FedRAMP feature.

@david-livefront
david-livefront force-pushed the fed-ramp-feature-flag branch from 7d26beb to c5d2b2b Compare July 2, 2026 18:11
@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront
david-livefront added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit 4612f4d Jul 2, 2026
23 checks passed
@david-livefront
david-livefront deleted the fed-ramp-feature-flag branch July 2, 2026 18:46
@david-livefront david-livefront changed the title feat: Add feature flag for FedRAMP PM-40651: feat: Add feature flag for FedRAMP Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants