[PM-40274] fix(authenticator): force LTR text direction for TOTP code display - #7162
Conversation
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
|
|
bbd7810 to
9d830ac
Compare
|
@david-livefront I made the changes to the files of the main app also . Please let me know if i missed any text field |
| .joinToString(separator = " "), | ||
| style = BitwardenTheme.typography.sensitiveInfoSmall, | ||
| style = BitwardenTheme.typography.sensitiveInfoSmall.copy( | ||
| textDirection = TextDirection.Ltr, |
9d830ac to
146e5ad
Compare
|
@david-livefront made the changes . The lint is quite strict that's why it took some time |
david-livefront
added
t:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7162 +/- ##
==========================================
- Coverage 85.89% 85.23% -0.67%
==========================================
Files 927 1066 +139
Lines 66232 67693 +1461
Branches 9640 9746 +106
==========================================
+ Hits 56892 57699 +807
- Misses 5887 6511 +624
- Partials 3453 3483 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@david-livefront Is this going as expected or need a fix? |
|
@jatinkumar2409 Everything went great! Thank you for your contribution, we really appreciate it. |
4 participants
🎟️ Tracking
#7150
📔 Objective
Forces TextDirection.Ltr on TOTP code displays (authCode and nextAuthCode) in VaultVerificationCodeItem.kt.
In Right-to-Left (RTL) locales (such as Hebrew or Arabic), space-separated TOTP codes (e.g. 123 456) were previously rendered in reverse visual order (456 123) due to Compose default BiDi handling. Adding TextDirection.Ltr ensures the 6-digit verification code always renders in standard LTR order regardless of the active app language.
📸 Screenshots
Before :
After:
