PM-40317: bug: All users must follow Master Password policies - #7163
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds Code Review DetailsNo blocking findings.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7163 +/- ##
==========================================
- Coverage 86.43% 86.36% -0.07%
==========================================
Files 912 912
Lines 65520 65633 +113
Branches 9610 9610
==========================================
+ Hits 56631 56684 +53
- Misses 5444 5504 +60
Partials 3445 3445
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| assertEquals( | ||
| emptyList<SyncResponseJson.Policy>(), | ||
| emptyList<PolicyView>(), |
There was a problem hiding this comment.
Minor issue of mismatched types. The test was still passing because the type was erased during runtime but I fixed it all the same 😄
|
Thanks @aj-rosado |
🎟️ Tracking
PM-40317
📔 Objective
This PR updates the policy rules to apply MasterPassword policies to all users.