Skip to content

PM-40317: bug: All users must follow Master Password policies - #7163

Merged
david-livefront merged 1 commit into
mainfrom
PM-40317-owner-admin-mp-policy
Jul 14, 2026
Merged

PM-40317: bug: All users must follow Master Password policies#7163
david-livefront merged 1 commit into
mainfrom
PM-40317-owner-admin-mp-policy

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-40317

📔 Objective

This PR updates the policy rules to apply MasterPassword policies to all users.

@david-livefront
david-livefront requested a review from a team as a code owner July 14, 2026 14:21
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug labels Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds PolicyType.MASTER_PASSWORD to the non-exempt branch of isOrganizationExemptFromPolicies in PolicyManagerImpl, so that org owners and admins are no longer exempt from Master Password policies in the legacy filtering flow. The change is minimal, matches the pattern of the other non-exempt policy types, and aligns with the stated objective (PM-40317). The accompanying test edit is a harmless type-parameter correction (SyncResponseJson.PolicyPolicyView in an emptyList assertion).

Code Review Details

No blocking findings.

  • PolicyManagerImpl.kt:161 — Behavior change only applies to the legacy flow (isPoliciesInAcceptedStateEnabled == false); the accepted-state flow delegates exemption to authSdkSource.filterPolicies. Confirmed this matches intent and existing conventions.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.36%. Comparing base (006bdbf) to head (fa68245).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7163      +/-   ##
==========================================
- Coverage   86.43%   86.36%   -0.07%     
==========================================
  Files         912      912              
  Lines       65520    65633     +113     
  Branches     9610     9610              
==========================================
+ Hits        56631    56684      +53     
- Misses       5444     5504      +60     
  Partials     3445     3445              
Flag Coverage Δ
app-data 17.41% <ø> (-0.02%) ⬇️
app-ui-auth-tools 18.81% <ø> (+0.22%) ⬆️
app-ui-platform 16.80% <ø> (-0.03%) ⬇️
app-ui-vault 28.14% <ø> (+<0.01%) ⬆️
authenticator 6.13% <ø> (-0.05%) ⬇️
lib-core-network-bridge 4.05% <ø> (-0.04%) ⬇️
lib-data-ui 1.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


assertEquals(
emptyList<SyncResponseJson.Policy>(),
emptyList<PolicyView>(),

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue of mismatched types. The test was still passing because the type was erased during runtime but I fixed it all the same 😄

@aj-rosado aj-rosado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront
david-livefront added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 8b5f102 Jul 14, 2026
29 of 31 checks passed
@david-livefront
david-livefront deleted the PM-40317-owner-admin-mp-policy branch July 14, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants