Skip to content

[PM-32685] Add PR to message if available#7164

Merged
mpbw2 merged 5 commits into
mainfrom
PM-23685/message-enhancement
Jul 14, 2026
Merged

[PM-32685] Add PR to message if available#7164
mpbw2 merged 5 commits into
mainfrom
PM-23685/message-enhancement

Conversation

@mpbw2

@mpbw2 mpbw2 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32685

📔 Objective

Add PR link (if available) and additional clarification to slack message

📸 Screenshots

Message if PR available:

🍒 android#2842 [PM-123456] Commit Message by Author
🧱 commit: android/release/2025.7.0@388947f0
💜 @group-mobile-qa etc...

Message if PR not available:

🍒 [PM-123456] Commit Message by Author
🧱 commit: android/release/2025.7.0@388947f0
💜 @group-mobile-qa etc...


Note: 💜 shown in above examples because github doesn't render :bitwarden-love:

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (006bdbf) to head (ed5dd7a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7164      +/-   ##
==========================================
- Coverage   86.43%   85.69%   -0.74%     
==========================================
  Files         912      941      +29     
  Lines       65520    67045    +1525     
  Branches     9610     9660      +50     
==========================================
+ Hits        56631    57454     +823     
- Misses       5444     6137     +693     
- Partials     3445     3454       +9     
Flag Coverage Δ
app-data 17.29% <ø> (-0.13%) ⬇️
app-ui-auth-tools 18.81% <ø> (+0.22%) ⬆️
app-ui-platform 16.56% <ø> (-0.27%) ⬇️
app-ui-vault 28.10% <ø> (-0.04%) ⬇️
authenticator 6.06% <ø> (-0.11%) ⬇️
lib-core-network-bridge 4.99% <ø> (+0.90%) ⬆️
lib-data-ui 1.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpbw2 mpbw2 added t:ci Change Type - Updates to automated workflows ai-review Request a Claude code review labels Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change to .github/workflows/send_slack_notification.yml, which enriches the Slack cherry-pick notification with the PR link (when derivable from the commit subject), commit author, and a formatted commit line. The two concerns raised in earlier review passes have been addressed: COMMIT_AUTHOR is now defined in the step env, and the multi-line corruption risk is mitigated by extracting only the first line of the commit message via head -n1 before it reaches $GITHUB_OUTPUT. PR-number extraction is best-effort and non-fatal (|| true), matching the documented "if available" behavior.

Code Review Details

No new findings at the reporting threshold.

Notes considered and not flagged:

  • PR-number extraction (grep -oE '#[0-9]+' | tail -n1) is an intentional best-effort heuristic documented as "if available"; a commit subject referencing an unrelated #NNNN without a merge suffix could mislink, but this is by design.
  • Untrusted commit-subject/author content still flows into the text= output and the payload: text: "..." scalar; a literal " in a commit subject could malform the payload. This overlaps with the existing unresolved thread on commit-message corruption and is not reopened here.

@mpbw2
mpbw2 marked this pull request as ready for review July 14, 2026 15:31
@mpbw2
mpbw2 requested a review from a team as a code owner July 14, 2026 15:31
Comment thread .github/workflows/send_slack_notification.yml Outdated
Comment thread .github/workflows/send_slack_notification.yml
@mpbw2
mpbw2 enabled auto-merge July 14, 2026 17:36

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mpbw2
mpbw2 added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 5c13e26 Jul 14, 2026
23 checks passed
@mpbw2
mpbw2 deleted the PM-23685/message-enhancement branch July 14, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants