[PM-32685] enhancements for testing - #7168
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed a CI-only change to Code Review DetailsNo findings. The change is well-scoped and follows safe GitHub Actions patterns. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7168 +/- ##
==========================================
+ Coverage 85.69% 85.94% +0.24%
==========================================
Files 941 1124 +183
Lines 67045 68200 +1155
Branches 9660 9799 +139
==========================================
+ Hits 57454 58612 +1158
+ Misses 6137 6065 -72
- Partials 3454 3523 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vvolkgang
left a comment
There was a problem hiding this comment.
Small ⛏️, not a blocker, everything else looks great!
| REPO_URL="${GITHUB_SERVER_URL}/${REPO}" | ||
| COMMIT_URL="${REPO_URL}/commit/${COMMIT_SHA}" | ||
| COMMIT_MESSAGE="$(gh api "repos/${REPO}/commits/${COMMIT_SHA}" --jq '.commit.message')" | ||
| COMMIT_AUTHOR="$(gh api "repos/${REPO}/commits/${COMMIT_SHA}" --jq '.commit.author.name')" |
There was a problem hiding this comment.
⛏️ we could fetch both message and author in a single call.
There was a problem hiding this comment.
Pull request overview
Updates the Slack notification workflow to better support manual “test” runs by allowing a specific commit SHA to be targeted and routing those notifications to a dedicated test channel without user pings.
Changes:
- Added
workflow_dispatchinput for a commit SHA and logic to fetch commit metadata viagh apifor manual runs. - Adjusted Slack message formatting to use
${REPO_NAME}and avoid Slack mentions during manual dispatch. - Added retrieval of an additional Slack webhook secret and conditionally selects which webhook to use.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Send slack notification | ||
| uses: slackapi/slack-github-action@af78098f536edbc4de71162a307590698245be95 # v3.0.1 | ||
| with: | ||
| webhook: ${{ steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-TEAM-ENG-MOBILE }} | ||
| webhook: ${{ github.event_name == 'workflow_dispatch' && steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-AUTOMATIONS-TEST-CHANNEL || steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-TEAM-ENG-MOBILE }} | ||
| webhook-type: incoming-webhook |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-32685
📔 Objective
androidwith${REPO_NAME}for cleaner copypasta📸 Screenshots