Skip to content

[PM-32685] enhancements for testing - #7168

Merged
mpbw2 merged 2 commits into
mainfrom
PM-32685/test-support
Jul 21, 2026
Merged

[PM-32685] enhancements for testing#7168
mpbw2 merged 2 commits into
mainfrom
PM-32685/test-support

Conversation

@mpbw2

@mpbw2 mpbw2 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32685

📔 Objective

  • Added support for testing specific commit hash from workflow dispatch
  • Test messages are posted to the automations test channel and exclude pings to any slack users
  • replaced android with ${REPO_NAME} for cleaner copypasta

📸 Screenshots

image

@mpbw2 mpbw2 added t:ci Change Type - Updates to automated workflows ai-review Request a Claude code review labels Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a CI-only change to .github/workflows/send_slack_notification.yml that adds a workflow_dispatch input to build test notifications from a specific commit SHA, routes dispatch notifications to a test Slack channel while stripping user pings, and generalizes hardcoded repo references to ${REPO_NAME}. Untrusted workflow_dispatch input is passed via an environment variable (INPUT_COMMIT) rather than inlined into the run script, and shell variables are properly quoted, avoiding script injection. The added contents: read permission is appropriately scoped for the new gh api commit lookup. The prior reviewer suggestion to fetch commit message and author in a single API call has already been addressed by the latest commit.

Code Review Details

No findings. The change is well-scoped and follows safe GitHub Actions patterns.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (5c13e26) to head (f2788b6).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7168      +/-   ##
==========================================
+ Coverage   85.69%   85.94%   +0.24%     
==========================================
  Files         941     1124     +183     
  Lines       67045    68200    +1155     
  Branches     9660     9799     +139     
==========================================
+ Hits        57454    58612    +1158     
+ Misses       6137     6065      -72     
- Partials     3454     3523      +69     
Flag Coverage Δ
app-data 18.90% <ø> (+1.61%) ⬆️
app-ui-auth-tools 19.02% <ø> (+0.21%) ⬆️
app-ui-platform 17.10% <ø> (+0.53%) ⬆️
app-ui-vault 27.87% <ø> (-0.24%) ⬇️
authenticator 6.13% <ø> (+0.06%) ⬆️
lib-core-network-bridge 4.03% <ø> (-0.97%) ⬇️
lib-data-ui 1.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpbw2
mpbw2 marked this pull request as ready for review July 15, 2026 21:10
@mpbw2
mpbw2 requested a review from a team as a code owner July 15, 2026 21:10
@mpbw2
mpbw2 enabled auto-merge July 15, 2026 21:10
@mpbw2
mpbw2 requested a review from vvolkgang July 15, 2026 21:13

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small ⛏️, not a blocker, everything else looks great!

REPO_URL="${GITHUB_SERVER_URL}/${REPO}"
COMMIT_URL="${REPO_URL}/commit/${COMMIT_SHA}"
COMMIT_MESSAGE="$(gh api "repos/${REPO}/commits/${COMMIT_SHA}" --jq '.commit.message')"
COMMIT_AUTHOR="$(gh api "repos/${REPO}/commits/${COMMIT_SHA}" --jq '.commit.author.name')"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ we could fetch both message and author in a single call.

Copilot AI review requested due to automatic review settings July 21, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Slack notification workflow to better support manual “test” runs by allowing a specific commit SHA to be targeted and routing those notifications to a dedicated test channel without user pings.

Changes:

  • Added workflow_dispatch input for a commit SHA and logic to fetch commit metadata via gh api for manual runs.
  • Adjusted Slack message formatting to use ${REPO_NAME} and avoid Slack mentions during manual dispatch.
  • Added retrieval of an additional Slack webhook secret and conditionally selects which webhook to use.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 82 to 86
- name: Send slack notification
uses: slackapi/slack-github-action@af78098f536edbc4de71162a307590698245be95 # v3.0.1
with:
webhook: ${{ steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-TEAM-ENG-MOBILE }}
webhook: ${{ github.event_name == 'workflow_dispatch' && steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-AUTOMATIONS-TEST-CHANNEL || steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-TEAM-ENG-MOBILE }}
webhook-type: incoming-webhook
@mpbw2
mpbw2 requested a review from vvolkgang July 21, 2026 16:53

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mpbw2
mpbw2 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 820098c Jul 21, 2026
24 checks passed
@mpbw2
mpbw2 deleted the PM-32685/test-support branch July 21, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants