Skip to content

PM-40497: bug: Update the plan price row announcement for accessibility - #7170

Merged
david-livefront merged 1 commit into
mainfrom
PM-40497-plan-price-announcement
Jul 16, 2026
Merged

PM-40497: bug: Update the plan price row announcement for accessibility#7170
david-livefront merged 1 commit into
mainfrom
PM-40497-plan-price-announcement

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-40497

📔 Objective

This PR updates the Price row on the PlanScreen to announce more human discernible text.

@david-livefront
david-livefront marked this pull request as ready for review July 16, 2026 14:23
@david-livefront
david-livefront requested a review from a team as a code owner July 16, 2026 14:23
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the accessibility fix to the PriceRow composable on PlanScreen. The change merges the price row's semantics into a single node with a human-readable contentDescription ("$1.67 per month, cancel anytime") and hides the individual Text children from accessibility, while leaving the visual text unchanged for sighted users. The Compose semantics pattern (mergeDescendants = true + explicit contentDescription + hideFromAccessibility()) is applied correctly, and the new string resource follows the codebase's existing _content_description naming convention.

Code Review Details

No findings. The change is small, well-scoped, and correct.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.38%. Comparing base (5c13e26) to head (0b6469e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7170      +/-   ##
==========================================
+ Coverage   85.69%   86.38%   +0.68%     
==========================================
  Files         941      881      -60     
  Lines       67045    64349    -2696     
  Branches     9660     9599      -61     
==========================================
- Hits        57454    55587    -1867     
+ Misses       6137     5317     -820     
+ Partials     3454     3445       -9     
Flag Coverage Δ
app-data 17.63% <0.00%> (+0.33%) ⬆️
app-ui-auth-tools 18.78% <0.00%> (-0.03%) ⬇️
app-ui-platform 16.52% <100.00%> (-0.05%) ⬇️
app-ui-vault 27.46% <0.00%> (-0.65%) ⬇️
authenticator 6.15% <0.00%> (+0.08%) ⬆️
lib-core-network-bridge 4.07% <0.00%> (-0.93%) ⬇️
lib-data-ui 1.14% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aj-rosado aj-rosado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront
david-livefront added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 1b8dbd7 Jul 16, 2026
23 of 27 checks passed
@david-livefront
david-livefront deleted the PM-40497-plan-price-announcement branch July 16, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants