PM-40657: feat: Add support for disableUserRegistration boolean

[david-livefront]

🎟️ Tracking

PM-35124
PM-40675
PM-40657

📔 Objective

This PR adds the setting to the ConfigResponseJson and uses that data to hide the Create account button on the Landing screen and the Welcome screen.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR adds a settings.disableUserRegistration field to ConfigResponseJson and uses it (alongside the existing FedRamp check) to hide the "Create account" button on the Landing and Welcome screens. The ViewModel wiring, state hoisting, and internal-action pattern follow established conventions, and test coverage for both ViewModels and screens is thorough. One robustness concern with the new network model is noted below.

Code Review Details

• ⚠️ : SettingJson.disableUserRegistration is non-nullable with no default; a present-but-partial settings object would throw MissingFieldException and break parsing of the entire config response. Other non-nullable Boolean fields in this layer default to false.
  • network/src/main/kotlin/com/bitwarden/network/model/ConfigResponseJson.kt:139

[codecov]

Codecov Report

❌ Patch coverage is 84.88372% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.08%. Comparing base (56277b3) to head (78c0abd).

Files with missing lines	Patch %	Lines
...warden/ui/auth/feature/landing/LandingViewModel.kt	79.16%	0 Missing and 5 partials ⚠️
...warden/ui/auth/feature/welcome/WelcomeViewModel.kt	85.29%	0 Missing and 5 partials ⚠️
...re/startregistration/StartRegistrationViewModel.kt	82.35%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7186      +/-   ##
==========================================
+ Coverage   85.94%   86.08%   +0.13%     
==========================================
  Files        1124      886     -238     
  Lines       68200    64756    -3444     
  Branches     9799     9683     -116     
==========================================
- Hits        58612    55742    -2870     
+ Misses       6065     5538     -527     
+ Partials     3523     3476      -47     

Flag	Coverage Δ
app-data	17.74% <0.00%> (-1.17%)	⬇️
app-ui-auth-tools	18.78% <84.88%> (-0.25%)	⬇️
app-ui-platform	16.55% <0.00%> (-0.56%)	⬇️
app-ui-vault	27.36% <0.00%> (-0.51%)	⬇️
authenticator	6.10% <0.00%> (-0.03%)	⬇️
lib-core-network-bridge	4.01% <0.00%> (-0.02%)	⬇️
lib-data-ui	1.15% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aj-rosado]

🤔 more of a thought, we are adding the disableCreateAccount for the FED_RAMP environment but we are keeping the hard check on the env.

As I believe we never want to display this on FED_RAMP env, also feel that it is more of a server responsability 🤔 also on other places we are simply relying on the disableUserRegistration value

[david-livefront]

This is the only screen that allows a full FedRamp type to be selected. Since we know the type directly here we can block account creation. Whereas on the StartRegistrationScreen, we completely filter out the FedRamp option. but the individual environments might still have the disableUserRegistration boolean set.

Keeping the check for the FED_RAMP type just means we do not need to wait for the config request go through. It's a minor optimization that was added to the requirements.

[aj-rosado]

LGTM, just left a little non blocking comment

[david-livefront]

Thanks @aj-rosado