Skip to content

PM-40699: feat: Add FedRamp base urls to EnvironmentScreen autocomplete - #7190

Merged
david-livefront merged 1 commit into
mainfrom
PM-40699-url-auto-complete
Jul 21, 2026
Merged

PM-40699: feat: Add FedRamp base urls to EnvironmentScreen autocomplete#7190
david-livefront merged 1 commit into
mainfrom
PM-40699-url-auto-complete

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-40699

📔 Objective

This PR adds the 3 FedRamp test environment domains to the Autocomplete dropdown.

@david-livefront
david-livefront requested a review from a team as a code owner July 21, 2026 19:08
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the refactor that moves the environment autocomplete list out of EnvironmentScreen into EnvironmentState, backed by a new Environment.DEFAULT_INTERNAL_ENVIRONMENTS list and a new BuildInfoManager.isReleaseBuild flag. The release-gating behavior is preserved: the original BUILD_TYPE != "release" check maps correctly to !isRelease, so release builds still receive an empty autocomplete list and the new internal/FedRamp URLs are never exposed in production. The isRelease field is part of the @Parcelize state, so it survives process death. Both BuildInfoManager implementations (app and authenticator) were updated, and existing tests were migrated cleanly.

Code Review Details

No blocking findings.

Minor, non-blocking observations (not posted inline):

  • Tests only exercise the release branch (isRelease = true / isReleaseBuild = true), so the newly populated non-release autocomplete branch is untested. This matches the pre-existing test posture (the old inline list was also untested), so it is not a regression.
  • The PR description mentions "3 FedRamp test environment domains", but the diff adds three URLs where only fedramp.usdev.bitwarden.pw is FedRamp-named (gw.dev and gw.stg are general dev/staging). Description wording only; no code impact.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.20%. Comparing base (c6f7a47) to head (c3714cd).

Files with missing lines Patch % Lines
...i/auth/feature/environment/EnvironmentViewModel.kt 0.00% 5 Missing ⚠️
...n/ui/auth/feature/environment/EnvironmentScreen.kt 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c6f7a47) and HEAD (c3714cd). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (c6f7a47) HEAD (c3714cd)
lib-data-ui 1 0
app-data 1 0
app-ui-auth-tools 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7190       +/-   ##
===========================================
- Coverage   86.19%   52.20%   -34.00%     
===========================================
  Files         884     1019      +135     
  Lines       64674    66635     +1961     
  Branches     9681     9644       -37     
===========================================
- Hits        55745    34784    -20961     
- Misses       5456    29718    +24262     
+ Partials     3473     2133     -1340     
Flag Coverage Δ
app-data ?
app-ui-auth-tools ?
app-ui-platform 17.08% <0.00%> (+0.52%) ⬆️
app-ui-vault 27.90% <0.00%> (+0.54%) ⬆️
authenticator 6.10% <0.00%> (-0.01%) ⬇️
lib-core-network-bridge 4.03% <0.00%> (+<0.01%) ⬆️
lib-data-ui ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrebispo5 andrebispo5 changed the title PM-40699: feat: Add FedRamp base urls to EnvironmentScreen autocomplete [PM-40699] feat: Add FedRamp base urls to EnvironmentScreen autocomplete Jul 21, 2026
@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @andrebispo5

@andrebispo5 andrebispo5 changed the title [PM-40699] feat: Add FedRamp base urls to EnvironmentScreen autocomplete PM-40699: feat: Add FedRamp base urls to EnvironmentScreen autocomplete Jul 21, 2026
@david-livefront
david-livefront added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit c2255ba Jul 21, 2026
25 of 26 checks passed
@david-livefront
david-livefront deleted the PM-40699-url-auto-complete branch July 21, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants