PM-39902: feat: Add data field for updating a cipher with Blob encryption

[david-livefront]

🎟️ Tracking

PM-39902

📔 Objective

This PT adds the data payload to the network request payloads responsible to for updating ciphers. This is required to ensure continued functionality with Blob encryption.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of a nullable data field to CipherJsonRequest and CipherWithIdJsonRequest to support Blob encryption on cipher updates. The field is threaded through Cipher.toEncryptedNetworkCipher and toCipherWithIdJsonRequest, and the createMockCipherJsonRequest test fixture is updated accordingly. The change is minimal, consistent with the existing nullable-field serialization pattern, and all direct constructor call sites route through the updated constructors or the fixture.

Code Review Details

No findings. The change is a straightforward passthrough of a new SDK field with no security, correctness, breaking-change, or performance concerns.

Minor (not blocking): the round-trip mapping is only exercised with data = null in tests (createMockSdkCipher sets data = null), so a non-null value is not covered. Given the mapping is a trivial passthrough, this is acceptable.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.70%. Comparing base (04edb4c) to head (7620575).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7198      +/-   ##
==========================================
- Coverage   86.20%   85.70%   -0.50%     
==========================================
  Files         884      896      +12     
  Lines       64672    65048     +376     
  Branches     9673     9688      +15     
==========================================
+ Hits        55751    55752       +1     
- Misses       5456     5831     +375     
  Partials     3465     3465              

Flag	Coverage Δ
app-data	17.76% <100.00%> (+<0.01%)	⬆️
app-ui-auth-tools	18.78% <0.00%> (-0.01%)	⬇️
app-ui-platform	16.55% <0.00%> (-0.01%)	⬇️
app-ui-vault	27.36% <0.00%> (-0.01%)	⬇️
authenticator	6.10% <0.00%> (-0.02%)	⬇️
lib-core-network-bridge	4.01% <0.00%> (-0.01%)	⬇️
lib-data-ui	1.15% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[andrebispo5]

Just to check, all other fields have non null mocked values shouldn't this have something also?

[david-livefront]

Good call, I added some fake data here and I also updated the SyncResponseCipherUtil to do the same thing

[david-livefront]

Thanks @andrebispo5