PM-40885: bug: Support overriding the colorscheme - #7206
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed this bug fix that preserves dynamic (Material You) colors on the QR Code Scan and Card Scan screens while still forcing them to render in dark mode. The change introduces a new Code Review DetailsNo blocking findings. Verified:
Minor (non-blocking, not posted inline): the KDoc on |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7206 +/- ##
==========================================
- Coverage 86.20% 85.86% -0.34%
==========================================
Files 884 1032 +148
Lines 64657 67403 +2746
Branches 9674 9771 +97
==========================================
+ Hits 55737 57878 +2141
- Misses 5456 6020 +564
- Partials 3464 3505 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @aj-rosado |
🎟️ Tracking
PM-40885
📔 Objective
This PR fixes a bug in the QR Code Scan Screen (Password Manager and Authenticator) and the Card Scan Screen where we would force the UI to be in dark mode but the dynamic colors would be lost. This change still forces dark mode but preserves the dynamic color setting.
📸 Screenshots
Screen_recording_20260723_155121.mp4
after.mp4