PM-41429: Chore: Decouple dependencies

[david-livefront]

🎟️ Tracking

PM-41429

📔 Objective

This PR decouples the FlightRecorderWriter and FileManager from the network layer. This will allow the Flight Recorder to be instantiated much sooner in the app lifecycle.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed this tech-debt refactor that decouples FileManager and FlightRecorderWriter from the network layer. FileManager.downloadFileToCache(url) is replaced by streamFileToCache(stream): Result<File>, with the DownloadService call moved up into CipherManagerImpl.downloadAttachment, and FlightRecorderWriterImpl now reads server config from ConfigDiskSource instead of ServerConfigRepository. The UuidManager provider moves from the authenticator's PlatformManagerModule to CoreManagerModule, and the now-unused DownloadResult model is deleted. Verified no leftover downloadFileToCache/DownloadResult references, a single UuidManager binding in the graph, and that ConfigDiskSource is available in both app graphs via the shared DiskModule.

Code Review Details

No findings.

Notes from validation (no action required):

• The ConfigDiskSource swap in FlightRecorderWriterImpl is behavior-preserving: ServerConfigRepositoryImpl.serverConfigStateFlow is a get() property that rebuilt a stateIn from configDiskSource.serverConfig on each access, so reading the disk source directly is equivalent and cheaper.
• streamFileToCache catching only RuntimeException (letting IOException escape a Result-returning function) and leaving the partial cache file on failure both match the pre-change implementation, so they are pre-existing rather than introduced here.
• The response body is still closed on the success path via stream.use { } inside streamFileToCache.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (b2ba4ec) to head (d8572eb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7238      +/-   ##
==========================================
- Coverage   85.72%   85.33%   -0.39%     
==========================================
  Files        1053     1112      +59     
  Lines       67779    68345     +566     
  Branches     9826     9849      +23     
==========================================
+ Hits        58101    58321     +220     
- Misses       6166     6514     +348     
+ Partials     3512     3510       -2     

Flag	Coverage Δ
app-data	18.00% <54.54%> (-0.26%)	⬇️
app-ui-auth-tools	19.21% <0.00%> (+0.17%)	⬆️
app-ui-platform	17.02% <0.00%> (+0.53%)	⬆️
app-ui-vault	27.83% <0.00%> (+<0.01%)	⬆️
authenticator	6.09% <0.00%> (-0.04%)	⬇️
lib-core-network-bridge	4.10% <0.00%> (-0.02%)	⬇️
lib-data-ui	1.20% <45.45%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[david-livefront]

Thanks @aj-rosado