Skip to content

[PM-35680] chore: Convert ServerCommunicationConfigRepository to AutoMockable#2790

Merged
matt-livefront merged 1 commit into
mainfrom
matt/PM-35680-sdk-mocks-server-communication-config-repo
Jun 15, 2026
Merged

[PM-35680] chore: Convert ServerCommunicationConfigRepository to AutoMockable#2790
matt-livefront merged 1 commit into
mainfrom
matt/PM-35680-sdk-mocks-server-communication-config-repo

Conversation

@matt-livefront

@matt-livefront matt-livefront commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-35680

📔 Objective

Updates ServerCommunicationConfigRepository to use AutoMockable.

@matt-livefront matt-livefront requested a review from a team as a code owner June 15, 2026 17:30
@matt-livefront matt-livefront added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Jun 15, 2026
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the conversion of ServerCommunicationConfigRepository's bespoke mock to a Sourcery AutoMockable-generated mock. The change deletes MockServerCommunicationConfigRepository.swift, registers the SDK protocol for AutoMockable in BitwardenSdkMocks.swift, and adds the BitwardenSdkMocks import to the singleton test. The generated mock keeps the same Mock<ProtocolName> name (per the AutoMockable.stencil Mock{{ type.name }} convention), and no test reads the deleted mock's bespoke recorded properties, so the API change is non-breaking.

Code Review Details

No findings. The conversion is correctly scoped:

  • Generated mock name MockServerCommunicationConfigRepository matches the deleted bespoke mock, so existing references in ServerCommunicationConfigClientSingletonTests.swift remain valid.
  • The new extension ServerCommunicationConfigRepository {} entry is alphabetically placed, consistent with the file's ordering.
  • No other test files reference the removed mock or its bespoke-only properties.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.01%. Comparing base (8c9d9eb) to head (e34d6ee).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
- Coverage   87.93%   87.01%   -0.92%     
==========================================
  Files        1728     1920     +192     
  Lines      168727   182955   +14228     
==========================================
+ Hits       148365   159200   +10835     
- Misses      20362    23755    +3393     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit 856d117 into main Jun 15, 2026
26 of 32 checks passed
@matt-livefront matt-livefront deleted the matt/PM-35680-sdk-mocks-server-communication-config-repo branch June 15, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants