Skip to content

[PM-35680] chore: Convert Fido2CredentialStore to AutoMockable#2804

Merged
matt-livefront merged 1 commit into
mainfrom
matt/PM-35680-sdk-mocks-fido2-credential-store
Jun 18, 2026
Merged

[PM-35680] chore: Convert Fido2CredentialStore to AutoMockable#2804
matt-livefront merged 1 commit into
mainfrom
matt/PM-35680-sdk-mocks-fido2-credential-store

Conversation

@matt-livefront

@matt-livefront matt-livefront commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-35680

📔 Objective

Updates Fido2CredentialStore to AutoMockable.

@matt-livefront matt-livefront requested a review from a team as a code owner June 17, 2026 21:22
@matt-livefront matt-livefront added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Jun 17, 2026
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the conversion of Fido2CredentialStore from the bespoke MockFido2CredentialStore to a Sourcery AutoMockable-generated mock. The change deletes the hand-written mock, registers the SDK type in the AutoMockable extension file, and migrates test call sites to the generated ReturnValue/ThrowableError/Called conventions. No production code is affected.

Code Review Details

No findings. Verification notes:

  • extension Fido2CredentialStore {} is correctly placed in alphabetical order in BitwardenSdkMocks.swift.
  • Test migrations map correctly: allCredentialsResult/findCredentialsResult*ReturnValue/*ThrowableError, and saveCredentialErrorsaveCredentialThrowableError. The preserved saveCredentialCalled assertion matches the AutoMockable-generated Called flag.
  • import BitwardenSdkMocks was added only to test files that previously lacked it; files already importing it (e.g. AutofillCredentialServiceTests, VaultAutofillListProcessor+Fido2Tests) were correctly left untouched.
  • The remaining findCredentialsResult references in Fido2CredentialStoreServiceTests belong to Fido2DebuggingReportBuilder's report object, not the mock, and are correctly unchanged.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.54%. Comparing base (f5067ec) to head (8045ba0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2804      +/-   ##
==========================================
- Coverage   80.80%   78.54%   -2.27%     
==========================================
  Files        1019     1142     +123     
  Lines       64849    72145    +7296     
==========================================
+ Hits        52402    56663    +4261     
- Misses      12447    15482    +3035     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit 89c4b7f into main Jun 18, 2026
26 of 30 checks passed
@matt-livefront matt-livefront deleted the matt/PM-35680-sdk-mocks-fido2-credential-store branch June 18, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants