[QA-2027] Add accessibilityIdentifier to Landing App settings button

[Corbet-BW]

🎟️ Tracking

QA-2027

📔 Objective

Adds a stable accessibilityIdentifier("AppSettingsButton") to the pre-login Landing screen's "App settings" button, so test automation can locate it by a stable ID instead of the localized label text. Matches the CreateAccountButton precedent on the same screen. No logic or UI change.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-line change to LandingView.swift adding a stable accessibilityIdentifier("AppSettingsButton") to the pre-login "App settings" button. The identifier follows the existing CreateAccountButton and ContinueButton precedents on the same screen, and the change introduces no logic or UI behavior. No security, correctness, or performance concerns found.

Code Review Details

No findings. The change is consistent with established accessibility identifier conventions in the file.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.81%. Comparing base (68caf09) to head (f169f4e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   80.82%   80.81%   -0.02%     
==========================================
  Files        1018     1021       +3     
  Lines       64941    64994      +53     
==========================================
+ Hits        52490    52524      +34     
- Misses      12451    12470      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.