[PM-39748] llm: Add skill to fix flaky tests - #2839
Merged
Merged
Conversation
… flaky tests for it to solve.
github-actions
Bot
added
the
t:llm
Contributor
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
- Coverage 81.25% 78.97% -2.29%
==========================================
Files 1028 1151 +123
Lines 66164 73459 +7295
==========================================
+ Hits 53760 58012 +4252
- Misses 12404 15447 +3043 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Correct the test plan mapping table (ViewInspector/Networking targets are not in BitwardenKit-Unit), fix try await for Swift Testing waitForAsync, and clarify order-dependence behavior between Default and Unit plans.
SaintPatrck
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-39748
📔 Objective
Adds a new
.claude/skills/fixing-flaky-tests/SKILL.mdskill for diagnosing and fixing intermittently failing tests in the Bitwarden iOS codebase.The skill guides Claude through a structured workflow: locate the test → diagnose the root cause → fix → stress-test 100 times → run the full unit suite → run build-test-verify
What the skill does
When a developer reports a flaky test by name, Claude will:
The skill references project-specific test helpers (waitFor, waitForAsync, withContinuationTimeout from SwiftTestingHelpers.swift / BaseBitwardenTestCase) and the TimeProvider protocol for time-dependent SUT fixes.