Skip to content

[PM-39759] ci: Increase test execution time allowance to 10 seconds#2840

Merged
fedemkr merged 1 commit into
mainfrom
PM-39759/increase-maximum-test-time-allowance
Jun 29, 2026
Merged

[PM-39759] ci: Increase test execution time allowance to 10 seconds#2840
fedemkr merged 1 commit into
mainfrom
PM-39759/increase-maximum-test-time-allowance

Conversation

@fedemkr

@fedemkr fedemkr commented Jun 29, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

PM-39759

📔 Objective

It has been seen that 3 seconds is not enough as maximum test execution time allowance as we keep getting failures as "Test exceeded execution time allowance of 3 seconds" on some tests that should be passing.
So we're getting a little more flexible by increasing it to 10 seconds which should cover all or most cases in CI testing as discussed internally.

@fedemkr
fedemkr requested a review from a team as a code owner June 29, 2026 16:31
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label Jun 29, 2026
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR raises the xcodebuild -maximum-test-execution-time-allowance value to 10 seconds in both test.yml (was 3) and test-bwa.yml (was 2) to reduce flaky CI failures from tests exceeding the prior allowance. The change is a single-flag adjustment per workflow, well within scope of the t:ci label and clearly justified by the linked ticket.

Code Review Details

No issues found. The change is limited to two CI workflow files, converging both per-test timeout allowances to a consistent 10-second value. No security, correctness, or breaking-change concerns; line continuations and flag syntax are preserved.

@fedemkr
fedemkr enabled auto-merge (squash) June 29, 2026 16:34
@fedemkr fedemkr added the enhancement New feature or request label Jun 29, 2026
@vvolkgang

Copy link
Copy Markdown
Member

@fedemkr are we sure they're aren't hanging? We didn't have tests taking longer than 1s unless they hanged or we had runner issues, most of them ran bellow 0.5s.

We can still try it out.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.91%. Comparing base (61cc961) to head (a97dc9d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2840      +/-   ##
==========================================
- Coverage   81.19%   78.91%   -2.28%     
==========================================
  Files        1026     1149     +123     
  Lines       65799    73098    +7299     
==========================================
+ Hits        53425    57685    +4260     
- Misses      12374    15413    +3039     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fedemkr
fedemkr merged commit 18f5c17 into main Jun 29, 2026
28 of 30 checks passed
@fedemkr
fedemkr deleted the PM-39759/increase-maximum-test-time-allowance branch June 29, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants