Skip to content

fix: Replace bank account icon with correct asset#2866

Merged
andrebispo5 merged 1 commit into
mainfrom
fix/bank-account-icon
Jul 8, 2026
Merged

fix: Replace bank account icon with correct asset#2866
andrebispo5 merged 1 commit into
mainfrom
fix/bank-account-icon

Conversation

@andrebispo5

@andrebispo5 andrebispo5 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40093

📔 Objective

Replace bank-account24.pdf with a corrected asset that uses black (template-renderable) fill instead of a hardcoded blue color. The previous asset had the brand blue embedded in the PDF, preventing iOS template rendering from applying the app's iconPrimary tint color consistently with all other vault list icons (Login, Card, Identity, Licence, Passport).

📸 Screenshots

Before After

…rsion

The previous bank-account24 asset had a hardcoded blue fill color, preventing
the app's tint color from being applied consistently with other vault list icons.
Replace with a black template icon so it renders correctly alongside Login,
Card, and Identity icons.
Copilot AI review requested due to automatic review settings July 8, 2026 09:20
@andrebispo5
andrebispo5 requested review from a team and matt-livefront as code owners July 8, 2026 09:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR replaces the bank-account24.pdf vault icon asset with a near-black, template-renderable version so iOS can apply the app's iconPrimary tint. The rendered asset was verified visually and matches the black/template style of the sibling vault type icons. The Contents.json already declares template-rendering-intent: template and preserves-vector-representation: true, so the corrected fill will now tint properly. No code, logic, security, or dependency changes are present.

Code Review Details

No findings. This is a low-risk, single binary asset replacement with correct imageset configuration and an adequate test plan for visual verification in light and dark mode.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.00%. Comparing base (5569548) to head (40b9401).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
- Coverage   81.28%   79.00%   -2.29%     
==========================================
  Files        1027     1150     +123     
  Lines       66123    73404    +7281     
==========================================
+ Hits        53748    57991    +4243     
- Misses      12375    15413    +3038     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrebispo5 andrebispo5 changed the title fix: Replace bank account icon with template-renderable version fix: Replace bank account icon with fixed version Jul 8, 2026
@andrebispo5 andrebispo5 changed the title fix: Replace bank account icon with fixed version fix: Replace bank account icon with correct asset Jul 8, 2026
@andrebispo5
andrebispo5 merged commit 85f3884 into main Jul 8, 2026
23 checks passed
@andrebispo5
andrebispo5 deleted the fix/bank-account-icon branch July 8, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants