Add get_live_version lane for checking published App Store versions - #2875
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the new Code Review DetailsNo blocking findings. The change is well-scoped, matches the intent described in the PR, and preserves output compatibility with the consuming |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
- Coverage 81.24% 78.98% -2.27%
==========================================
Files 1028 1151 +123
Lines 66164 73459 +7295
==========================================
+ Hits 53756 58018 +4262
- Misses 12408 15441 +3033 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add new Fastlane lane that checks the actual live/published version on the App Store (READY_FOR_SALE state) rather than just the latest submitted version. This is needed for managed App Store publishing where apps are submitted and approved but not immediately published. The existing get_latest_version lane returns approved versions even if they haven't been released to users. The new get_live_version lane: - Uses Spaceship ConnectAPI to authenticate with App Store Connect - Calls get_live_app_store_version to get the version users can download - Outputs version_name and version_number in same format as get_latest_version - Returns empty strings if no live version exists This will be used by bitwarden/deploy workflows to only publish GitHub releases once the app version is actually available to users.
47f1f8c to
41cbcf2
Compare
Summary
Adds a new Fastlane lane
get_live_versionthat checks the actual live/published version on the App Store (READY_FOR_SALE state) rather than just the latest submitted version.Problem
With managed App Store publishing enabled, apps can be:
The existing
get_latest_versionlane usesapp_store_build_numberwhich returns the latest build submitted to the App Store, including approved versions that haven't been published yet. This causes thebitwarden/deployworkflows to publish GitHub releases prematurely - before users can actually download the app.Solution
The new
get_live_versionlane:get_live_app_store_versionto get only the version users can currently downloadget_latest_version(version_name and version_number)Usage
Related
This will be consumed by:
publish-ios-password-manager.ymlin bitwarden/deploypublish-ios-authenticator.ymlin bitwarden/deployRelated deploy PR: https://github.com/bitwarden/deploy/pull/[TBD]
Testing
After merging both PRs:
publish-ios-*workflows do NOT publish the GitHub release