Skip to content

[PM-32685] enhancements for testing - #2885

Merged
mpbw2 merged 3 commits into
mainfrom
PM-32685/test-support
Jul 21, 2026
Merged

[PM-32685] enhancements for testing#2885
mpbw2 merged 3 commits into
mainfrom
PM-32685/test-support

Conversation

@mpbw2

@mpbw2 mpbw2 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32685

📔 Objective

  • Added support for testing specific commit hash from workflow dispatch
  • Test messages are posted to the automations test channel and exclude pings to any slack users
  • replaced ios with ${REPO_NAME} for cleaner copypasta

📸 Screenshots

image

@mpbw2 mpbw2 added t:ci Change Type - Updates to automated workflows ai-review Request a Claude code review labels Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change to .github/workflows/send_slack_notification.yml, which adds a workflow_dispatch test path that builds a notification from an arbitrary commit SHA, routes test messages to the automations test channel, suppresses user pings, and generalizes hardcoded ios references to ${REPO_NAME}. Untrusted workflow_dispatch input is passed through env: variables rather than interpolated directly into the run script, which is the recommended safe pattern and avoids shell/script injection. The added contents: read permission is appropriately scoped to support the gh api commit lookup. No blocking findings.

Code Review Details

No findings at or above the reporting threshold.

@mpbw2
mpbw2 marked this pull request as ready for review July 15, 2026 21:10
@mpbw2
mpbw2 requested a review from a team as a code owner July 15, 2026 21:10
@mpbw2
mpbw2 enabled auto-merge (squash) July 15, 2026 21:10
@mpbw2
mpbw2 requested a review from vvolkgang July 15, 2026 21:13
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.85%. Comparing base (5cbc8eb) to head (00a4986).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
- Coverage   81.26%   78.85%   -2.42%     
==========================================
  Files        1028     1159     +131     
  Lines       66164    74265    +8101     
==========================================
+ Hits        53768    58559    +4791     
- Misses      12396    15706    +3310     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings July 21, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds workflow-dispatch support to the Slack notification workflow so test notifications can be generated for an explicit commit SHA and routed to a non-production Slack channel without user pings.

Changes:

  • Add a workflow_dispatch input for a commit SHA and fetch commit metadata via gh api.
  • Route workflow_dispatch notifications to the Automations test Slack webhook and suppress Slack user mentions in the message.
  • Replace hardcoded ios text in Slack links with ${REPO_NAME}.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 82 to 88
- name: Send slack notification
uses: slackapi/slack-github-action@af78098f536edbc4de71162a307590698245be95 # v3.0.1
with:
webhook: ${{ steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-TEAM-ENG-MOBILE }}
webhook: ${{ github.event_name == 'workflow_dispatch' && steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-AUTOMATIONS-TEST-CHANNEL || steps.retrieve-slack-secrets.outputs.SLACK-WEBHOOK-TEAM-ENG-MOBILE }}
webhook-type: incoming-webhook
payload: |
text: "${{ steps.msg.outputs.text }}"

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mpbw2
mpbw2 merged commit 74dac7f into main Jul 21, 2026
20 of 21 checks passed
@mpbw2
mpbw2 deleted the PM-32685/test-support branch July 21, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants