Skip to content

[PM-40225] chore: Update filtered files in spellchecking - #2887

Merged
LRNcardozoWDF merged 4 commits into
mainfrom
cmcg/pm-40225-update-filtered-files-in-spellchecking
Jul 23, 2026
Merged

[PM-40225] chore: Update filtered files in spellchecking#2887
LRNcardozoWDF merged 4 commits into
mainfrom
cmcg/pm-40225-update-filtered-files-in-spellchecking

Conversation

@LRNcardozoWDF

@LRNcardozoWDF LRNcardozoWDF commented Jul 17, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

PM-40225

📔 Objective

Updates the filtered list to also ignore public_suffix_list.dat and all localization files except the files inside en.lproj.

@LRNcardozoWDF
LRNcardozoWDF requested review from a team and matt-livefront as code owners July 17, 2026 13:21
@github-actions github-actions Bot added the t:tech-debt Change Type - Tech debt label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the single change to Scripts/spellcheck-changes.sh, which adds two exclusion patterns to the spell-check file filter: public_suffix_list.dat and all *.lproj/ localization files except those under en.lproj/. Traced both glob patterns against the repository's actual file layout and confirmed they filter the intended files while correctly preserving en.lproj content. The documentation comment block was updated to match the new logic.

Code Review Details

No blocking findings.

The */en.lproj/* exception relies on a leading */, so it only matches nested en.lproj folders. All en.lproj directories in this repo are nested, so the behavior is correct as written.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.88%. Comparing base (dcb508d) to head (ae7d795).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2887      +/-   ##
==========================================
- Coverage   81.11%   78.88%   -2.23%     
==========================================
  Files        1037     1160     +123     
  Lines       67030    74327    +7297     
==========================================
+ Hits        54373    58635    +4262     
- Misses      12657    15692    +3035     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small nitpick

Comment thread Scripts/spellcheck-changes.sh Outdated
# - Files under *.xcassets/ folders
# - Files under AppIcon-*.icon/ folders
# - Files under BitwardenResources/Fonts/
# - File */public_suffix_list.dat

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Should these be in the same order as in the checks?

@LRNcardozoWDF
LRNcardozoWDF merged commit 9ca63cc into main Jul 23, 2026
15 checks passed
@LRNcardozoWDF
LRNcardozoWDF deleted the cmcg/pm-40225-update-filtered-files-in-spellchecking branch July 23, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants