Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 24, 2025

This PR contains the following updates:

Package Update Change
rust minor 1.87.0 -> 1.91.1

Release Notes

rust-lang/rust (rust)

v1.91.1

Compare Source

===========================

v1.91.0

Compare Source

==========================

Language

Compiler

Platform Support

Refer to Rust's platform support page
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These previously stable APIs are now stable in const contexts:

Cargo

  • 🎉 Stabilize build.build-dir.
    This config sets the directory where intermediate build artifacts are stored.
    These artifacts are produced by Cargo and rustc during the build process.
    End users usually won't need to interact with them, and the layout inside
    build-dir is an implementation detail that may change without notice.
    (config doc)
    (build cache doc)
    #​15833
    #​15840
  • The --target flag and the build.target configuration can now take literal
    "host-tuple" string, which will internally be substituted by the host
    machine's target triple.
    #​15838
    #​16003
    #​16032

Rustdoc

Compatibility Notes

Cargo compatibility notes:

  • cargo publish no longer keeps .crate tarballs as final build artifacts
    when build.build-dir is set. These tarballs were previously included due to
    an oversight and are now treated as intermediate artifacts.
    To get .crate tarballs as final artifacts, use cargo package.
    In a future version, this change will apply regardless of build.build-dir.
    #​15910
  • Adjust Cargo messages to match rustc diagnostic style.
    This changes some of the terminal colors used by Cargo messages.
    #​15928
  • Tools and projects relying on the
    internal details of Cargo's build-dir
    may not work for users changing their build-dir layout.
    For those doing so, we'd recommend proactively testing these cases
    particularly as we are considering changing the default location of the build-dir in the future
    (cargo#16147).
    If you can't migrate off of Cargo's internal details,
    we'd like to learn more about your use case as we prepare to change the layout of the build-dir
    (cargo#15010).

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

v1.90.0

Compare Source

===========================

Language

Compiler

Platform Support

Refer to Rust's platform support page
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These previously stable APIs are now stable in const contexts:

Cargo

Rustdoc

Compatibility Notes

v1.89.0

Compare Source

==========================

Language

Compiler

Platform Support

Refer to Rust's platform support page
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These previously stable APIs are now stable in const contexts:

Cargo

Rustdoc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

v1.88.0

Compare Source

==========================

Language

Compiler

Platform Support

Refer to Rust's platform support page
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These previously stable APIs are now stable in const contexts:

Cargo

Rustdoc

Compatibility Notes


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner November 24, 2025 02:52
@renovate renovate bot requested a review from djsmith85 November 24, 2025 02:52
@bitwarden-bot bitwarden-bot changed the title [deps]: Update Rust to v1.91.1 [PM-28730] [deps]: Update Rust to v1.91.1 Nov 24, 2025
@bitwarden-bot
Copy link

Internal tracking:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: renovate/rust (9181f01)
Completed: 2025-12-08 13:53:53 UTC
Total Time: 215s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.59%. Comparing base (ab7ae36) to head (9181f01).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   79.74%   78.59%   -1.15%     
==========================================
  Files         304      281      -23     
  Lines       32757    29130    -3627     
==========================================
- Hits        26121    22895    -3226     
+ Misses       6636     6235     -401     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot changed the title [PM-28730] [deps]: Update Rust to v1.91.1 [deps]: Update Rust to v1.91.1 Nov 24, 2025
@djsmith85 djsmith85 requested review from dani-garcia and removed request for djsmith85 November 25, 2025 11:00
@renovate
Copy link
Contributor Author

renovate bot commented Dec 8, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@claude
Copy link

claude bot commented Dec 8, 2025

Claude finished @renovate[bot]'s task —— View job


Code Review: Rust 1.87.0 → 1.91.1 Update

Summary

This PR updates the Rust toolchain from 1.87.0 to 1.91.1 and adds a clippy lint allowance for auto-generated API code. The changes are minimal, well-contained, and appropriate.

Review

✅ Rust Version Update (rust-toolchain.toml)

  • Change: 1.87.01.91.1
  • Assessment: This is a minor version update spanning 4 releases (1.88, 1.89, 1.90, 1.91)
  • Notable Features: Based on the release notes, this brings important improvements:
    • LLVM 21 update (1.91.0)
    • Various stabilized APIs and language features
    • Bug fixes including WASM linker issues and illumos file locking
    • Multiple security and compatibility fixes
  • Risk: Low - CI shows no breaking changes detected for TypeScript clients

✅ Clippy Lint Allowance Addition

  • Change: Added clippy::derivable_impls to allow list in generated code
  • Files affected:
    • crates/bitwarden-api-api/src/lib.rs:10
    • crates/bitwarden-api-identity/src/lib.rs:10
    • support/openapi-template/lib.mustache:9
  • Assessment: Appropriate for auto-generated code. The derivable_impls lint warns when Default impls could use #[derive(Default)]. For generated code, it's reasonable to suppress this rather than regenerate the code.
  • Consistency: ✅ Properly applied to both generated crates AND the template, ensuring future regenerations will include this allowance

✅ Code Generation Pattern

  • The changes follow the correct pattern for handling generated code:
    1. Update the template (lib.mustache)
    2. Update the generated files to match
  • This ensures consistency and prevents drift

Compatibility Notes from Release Notes

Potential Concerns Reviewed:

  • ✅ ABI changes for WASM (wasm32-unknown-unknown) - Not applicable unless using C FFI on WASM
  • lld now default on x86_64-unknown-linux-gnu (1.90.0) - Should improve build times
  • ✅ Various deprecated features removed - None appear to affect this codebase
  • ✅ Borrow checker and type inference changes - CI passing indicates no issues

Security Considerations

  • ✅ No security vulnerabilities introduced (per Checkmarx scan)
  • ✅ Update includes security fixes from intermediate releases
  • ✅ No unsafe code patterns affected by this change

Recommendations

✅ Approve - This PR is ready to merge

Reasoning:

  1. Clean dependency update with no breaking changes detected
  2. Proper handling of new clippy warnings for generated code
  3. Consistent application across template and generated files
  4. CI checks passing (including cross-repo TypeScript compilation)
  5. Brings important bug fixes and improvements from 4 Rust releases

Minor Note: The coverage decrease from 79.54% to 78.36% shown by Codecov appears to be unrelated to these changes (likely due to changes in what files are included in coverage calculation, possibly related to the generated code changes).


@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Logo
Checkmarx One – Scan Summary & Detailsa4a89806-5fdd-4096-aada-193dc92282ee

Great job! No new security vulnerabilities introduced in this pull request

@dani-garcia
Copy link
Member

@djsmith85 Adding you back for review as I had to make some changes to disable some new lints in autogenerated code, otherwise the version bump looks good to me.

@dani-garcia dani-garcia requested a review from djsmith85 December 8, 2025 14:19
@dani-garcia dani-garcia merged commit 7840f55 into main Dec 8, 2025
58 checks passed
@dani-garcia dani-garcia deleted the renovate/rust branch December 8, 2025 16:22
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Dec 8, 2025
@iinuwa iinuwa mentioned this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants