Merged
Conversation
Event Grid returns the blob path, which will be used to grab a Send and verify file size
Increment access count only when file is downloaded. File name and size are leaked, but this is a good first step toward solving the access-download race
This was referenced Mar 1, 2021
cscharf
reviewed
Mar 1, 2021
Contributor
cscharf
left a comment
cscharf
left a comment
There was a problem hiding this comment.
Looks good, just some odd formatting made it in
src/Core/Services/Implementations/AzureSendFileStorageService.cs
Outdated
Show resolved
Hide resolved
cscharf
approved these changes
Mar 1, 2021
This was referenced Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Splits out Send download links from #1167. Keeps the changes to blob/file storage scheme to enable upload events in the future, but I'm running out of dev time and want to get downloads fixed.
This PR is a companion to bitwarden/jslib#288
Files Changed