Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Use download link requests#859

Merged
MGibson1 merged 3 commits intomasterfrom
direct-download-links
Mar 2, 2021
Merged

Use download link requests#859
MGibson1 merged 3 commits intomasterfrom
direct-download-links

Conversation

@MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Mar 1, 2021

Overview

Implements download link request scheme from bitwarden/jslib#288 and bitwarden/server#1174.

Files Changed

  • access.component.ts: request download link.
  • messages.json: report if file cannot be found due to missing download link.

Draft reason

Depends on bitwarden/jslib#288

@MGibson1 MGibson1 requested a review from a team March 1, 2021 18:27
Copy link
Contributor

@cscharf cscharf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go once jslib rolls in.

@MGibson1
Copy link
Member Author

MGibson1 commented Mar 1, 2021

holding off on this PR for bitwarden/jslib#289

cscharf
cscharf previously approved these changes Mar 2, 2021
@MGibson1 MGibson1 force-pushed the direct-download-links branch from e01ddec to ad54b1e Compare March 2, 2021 16:02
@MGibson1 MGibson1 marked this pull request as ready for review March 2, 2021 16:03
@MGibson1 MGibson1 requested a review from cscharf March 2, 2021 16:03
@MGibson1 MGibson1 merged commit 227f457 into master Mar 2, 2021
@MGibson1 MGibson1 deleted the direct-download-links branch March 2, 2021 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants