Set Id property of Device to force a save instead of a create#2420
Merged
Set Id property of Device to force a save instead of a create#2420
Conversation
…ne instead of updating existing.
differsthecat
approved these changes
Nov 18, 2022
Member
differsthecat
left a comment
There was a problem hiding this comment.
Makes sense and looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
In this PR, I added logic to save a known device regardless of whether it existed or not, in order to always update the push token (if there was one on the request). In doing so, I introduced a bug in which it attempted to always do a "Create" on the
Devicetable for existing devices. TheSaveAsync()method determines whether to create or update based on the presence of theIdproperty. I missed setting theIdof the device to the one previously retrieved.Code changes
Idproperty on the request.Before you submit
dotnet format --verify-no-changes) (required)