[SG-823] Undid changes to capture device push token on login#2427
Merged
[SG-823] Undid changes to capture device push token on login#2427
Conversation
differsthecat
approved these changes
Dec 12, 2022
Member
differsthecat
left a comment
There was a problem hiding this comment.
This looks good. The only difference I see is that you kept the test changes you did in the previous PR intentionally 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
In #2404 and #2420, I introduced a change that moved the
SaveAsync()for devices so that it saves the device on every login, not just the initial login for that device. The intent was to allow the push token to be sent on the login request and updated at that time.In the meantime, I have discovered another way to solve this problem more directly and efficiently in the Bitwarden mobile codebase. These changes are included in this mobile PR. Doing these changes will make saving the push token on login redundant and add in a database call on every login for no reason.
This PR reverts those changes in
BaseRequestValidator.Code changes
Before you submit
dotnet format --verify-no-changes) (required)