Conversation
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7509 +/- ##
==========================================
- Coverage 59.10% 59.10% -0.01%
==========================================
Files 2078 2078
Lines 91705 91699 -6
Branches 8152 8151 -1
==========================================
- Hits 54201 54195 -6
Misses 35572 35572
Partials 1932 1932 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sven-bitwarden
approved these changes
Apr 20, 2026
harr1424
deleted the
PM-34427-Defect-Users-can-edit-and-save-sends-with-the-hide-email-address-option-enabled
branch
harr1424
added a commit
that referenced
this pull request
Apr 20, 2026
…ess option enabled (#7511) * fix sync bug (#7509) (cherry picked from commit 7c20581) * [deps] Tools: Update MailKit to 4.16.0 [SECURITY] (#7502) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 327290c) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34427
📔 Objective
Existing Policy Sync logic (SendControls, SendOptions, and DisableSend sync events) was pre-assigning a valid GUID to new Policy entities before calling UpsertAsync, which routed to Policy_Update and silently affected 0 rows instead of inserting.
The Id is now left as default(Guid) so UpsertAsync correctly routes to CreateAsync on first sync. Only first-time syncs were affected (when no legacy/target row existed yet), which is why this behavior appeared intermittent.