Extract Serilog file logging into Libraries/SerilogFileLogging - #8149
Conversation
Moves AddSerilogFileLogging and its tests out of Core into a dedicated library so services that need file logging can depend on it directly without taking a dependency on Core.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR extracts Code Review Details
Minor, not commented inline: the two new test files omit the UTF-8 BOM that |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8149 +/- ##
==========================================
+ Coverage 62.88% 67.48% +4.60%
==========================================
Files 2312 2312
Lines 100299 100325 +26
Branches 9021 9022 +1
==========================================
+ Hits 63070 67703 +4633
+ Misses 35053 30343 -4710
- Partials 2176 2279 +103 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…helper Add SerilogFileLogging and SerilogFileLogging.Test to bitwarden-server.slnx so both projects appear in Test Explorer and are included in dotnet format lint. Replace the TempDirectory IDisposable helper with Directory.CreateTempSubdirectory(), consistent with the other tests in the file, and delete the now-unused class.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34566
📔 Objective
Moves
AddSerilogFileLoggingand its tests out ofCoreinto a newsrc/Libraries/SerilogFileLogginglibrary.This allows services that need file logging to take a direct dependency on the library without depending on
Core, supporting the broader effort to decompose Core into smaller, more focused libraries (ADR-0032).Corecontinues to reference the library transitively for now, so existing consumers are unaffected.