QA-2279: add OrganizationEventScene to the seeder - #8175
Open
awiester-bw wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8175 +/- ##
=======================================
Coverage 63.35% 63.35%
=======================================
Files 2337 2337
Lines 101412 101412
Branches 9159 9159
=======================================
+ Hits 64248 64249 +1
+ Misses 34951 34950 -1
Partials 2213 2213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/QA-2279
📔 Objective
The SeederApi can create organizations, members, collections, and groups, but has no way to create audit events. This blocks per-test seeding for the Events Public API test class, whose positive cases read events back from
GET /public/eventsand need an org that already has some. This addsOrganizationEventScene, mirroringOrganizationGroupScene: it resolves the org, then writesCountaudit-event rows (default 2) for it throughIEventRepository, returning how many were seeded. The reflection-based scene registration picks it up automatically by class name.It targets the self-host SQL event store (
[dbo].[Event]), which is what qa-automation runs, andGET /public/eventsreads that same store there. The cloud Table Storage path (which needsEventTableEntityindexing) is out of scope and noted on the ticket. Verified by a passing build (0 warnings, warnings-as-errors on),dotnet format --verify-no-changes, and the pr-review-toolkit agent pass. No scene has a dedicated test harness in this repo (sibling scenes are untested), so no unit test was added, consistent with precedent.