Skip to content

[PM-41917] Add lit inline menu feature flag to server - #8198

Merged
dan-livefront merged 1 commit into
mainfrom
PM-41917-add-lit-inline-menu-feature-flag-to-server
Aug 13, 2026
Merged

[PM-41917] Add lit inline menu feature flag to server#8198
dan-livefront merged 1 commit into
mainfrom
PM-41917-add-lit-inline-menu-feature-flag-to-server

Conversation

@dan-livefront

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41917

📔 Objective

Add LitInlineMenuComponents = "lit-inline-menu-components"; to the server

@dan-livefront dan-livefront self-assigned this Aug 13, 2026
@dan-livefront dan-livefront added ai-review Request a Claude code review t:misc Change Type - ¯\_(ツ)_/¯ Prefer using other type labels labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single feature flag constant LitInlineMenuComponents = "lit-inline-menu-components" to FeatureFlagKeys in src/Core/Constants.cs. The constant is placed in the Autofill Team section, matches the naming style of neighboring flags in that block, and is not duplicated elsewhere in the codebase. No security, correctness, or breaking-change concerns identified.

Code Review Details

No findings.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.17%. Comparing base (643e3aa) to head (6ee0f1c).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (643e3aa) and HEAD (6ee0f1c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (643e3aa) HEAD (6ee0f1c)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8198      +/-   ##
==========================================
- Coverage   68.41%   63.17%   -5.24%     
==========================================
  Files        2380     2381       +1     
  Lines      103679   103771      +92     
  Branches     9386     9394       +8     
==========================================
- Hits        70931    65559    -5372     
- Misses      30420    35981    +5561     
+ Partials     2328     2231      -97     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-livefront
dan-livefront merged commit d9325ae into main Aug 13, 2026
49 of 53 checks passed
@dan-livefront
dan-livefront deleted the PM-41917-add-lit-inline-menu-feature-flag-to-server branch August 13, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:misc Change Type - ¯\_(ツ)_/¯ Prefer using other type labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants