Skip to content

Docs/documentation standard compliance - #204

Draft
MGibson1 wants to merge 2 commits into
mainfrom
docs/documentation-standard-compliance
Draft

Docs/documentation standard compliance#204
MGibson1 wants to merge 2 commits into
mainfrom
docs/documentation-standard-compliance

Conversation

@MGibson1

@MGibson1 MGibson1 commented Aug 4, 2026

Copy link
Copy Markdown
Member

📔 Objective

Ensure compliance with new README requirements from the get-go. (see documentation standards PR)

This repository is only responsible for initializing repositories in a good state, so the actual long-term requirements of READMEs are kept in contributing-docs

A created repo should not ship a README about
being a template, so the file is now the skeleton that new repos start
from: what the repo is, a Getting started section linking the
contributing site, a Structure map for monorepos, and Related
repositories.

Commenting decisions were made based on what is true of an initialized repository. Git hooks remain rendered, but instructions on updating linters do not
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the README skeleton and .claude/CLAUDE.md stub against the documentation standard proposed in contributing-docs#842, which routes the root README format to this repo. Both files are template scaffolding with no executable code, so the review focused on broken references, placeholder correctness, and whether the guidance is actionable for someone bootstrapping a new repo. The .claude/CONTRIBUTING.md reference resolves, the moved linter guidance is still preserved in the lint.yml and .githooks/pre-commit headers, and the empty Structure table is Prettier-clean.

Code Review Details
  • ❓ : /bitwarden-init:init is referenced but .claude/settings.json registers only the marketplace, not the plugin
    • .claude/CLAUDE.md:6

Also noted, not blocking: the README links https://contributing.bitwarden.com/contributing/documentation, whose index page is added by the still-open contributing-docs#842, so the link stays dead until that PR merges.

Comment thread .claude/CLAUDE.md
<!--
Template guidance — delete this comment when customizing your new repo.

Run /bitwarden-init:init to generate this file from an analysis of your

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QUESTION: Will /bitwarden-init:init resolve in a fresh clone of a repo made from this template?

Details

.claude/settings.json declares extraKnownMarketplaces for bitwarden-marketplace, which makes the marketplace known but does not install or enable any plugin from it. Without an enabledPlugins entry (or a prior /plugin install), /bitwarden-init:init is an unknown slash command, and this comment is the only actionable instruction the file gives.

Two options depending on intent:

  • Enable it in .claude/settings.json so the command works out of the box:
    "enabledPlugins": { "bitwarden-init@bitwarden-marketplace": true }
  • Or, if you'd rather not permanently enable a one-shot bootstrap plugin in every derived repo, name the install step in the comment:
    Run /plugin install bitwarden-init@bitwarden-marketplace, then /bitwarden-init:init …

Either way the reader isn't left guessing why the command isn't there.

@withinfocus withinfocus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a bold set of expectations for the Claude instructions but the init plugin should cover us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants