Skip to content

Security patches#3196

Merged
liquidsec merged 5 commits into
devfrom
dev-security-patches
Jun 16, 2026
Merged

Security patches#3196
liquidsec merged 5 commits into
devfrom
dev-security-patches

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • Harden docker_pull WWW-Authenticate parsing and realm validation
  • Add path traversal check to unarchive module
  • Reject symlinks in github_workflows output path before mkdir

Walk each path component between the trusted output_dir and the
target folder, refusing to proceed if any component is a symlink.
This prevents a local attacker from redirecting file writes by
pre-planting a symlink at the predictable owner/repo path.
@liquidsec liquidsec changed the title Security patches for dev Security patches Jun 16, 2026
- unarchive: detect symlink/hardlink entries in archives
- github_workflows: check output_dir itself for symlinks
- github_workflows: sanitize artifact_name with Path.name
@liquidsec liquidsec mentioned this pull request Jun 16, 2026
28 tasks
@ausmaster ausmaster self-requested a review June 16, 2026 18:49
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.12195% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (015020c) to head (2bdec88).

Files with missing lines Patch % Lines
bbot/modules/github_workflows.py 80% 4 Missing ⚠️
bbot/modules/internal/unarchive.py 86% 4 Missing ⚠️
...tep_2/module_tests/test_module_github_workflows.py 95% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #3196    +/-   ##
======================================
+ Coverage     90%     90%    +1%     
======================================
  Files        449     449            
  Lines      44451   44649   +198     
======================================
+ Hits       39765   39965   +200     
+ Misses      4686    4684     -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit 3b43e43 into dev Jun 16, 2026
17 checks passed
@liquidsec liquidsec deleted the dev-security-patches branch June 16, 2026 19:51
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 16, 2026
@liquidsec liquidsec mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants