Add verify_ssl passthrough, bump to 11.1.0#278
Merged
Conversation
11.0 release
Adds a `verify_ssl` keyword argument to the CloudCheck constructor (Rust `with_config` + PyO3 binding) mapping to reqwest's `danger_accept_invalid_certs`. Lets callers disable SSL verification when fetching cloud provider signatures (corporate proxies, custom CAs, SSL-intercepting infrastructure). Defaults to True. Closes #272; unblocks bbot#3226 (ssl_verify_infrastructure passthrough). - src/lib.rs: verify_ssl field; build a reqwest::Client with danger_accept_invalid_certs(!verify_ssl) instead of the default client; warn when verification is disabled - src/python.rs: verify_ssl=None kwarg passed through to with_config - bump 11.0.0 -> 11.1.0 (Cargo.toml, pyproject.toml, lockfiles) - docker-tests.yml: image tags v11.0/v11.0.0 -> v11.1/v11.1.0 - tests: Rust + Python coverage for verify_ssl=False
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts v11.1.0, implementing the cloudcheck side of bbot#3226 — its blocking dependency, #272: a
verify_sslconstructor parameter so SSL certificate verification can be disabled when fetching cloud provider signatures (corporate proxies, custom CAs, SSL-intercepting infrastructure).Changes
src/lib.rs— newverify_ssl: boolfield onCloudCheck, threaded throughwith_config(defaults totrue). The signature fetch now builds areqwest::Clientwith.danger_accept_invalid_certs(!verify_ssl)instead of the bare default client, and logs a warning when verification is disabled.src/python.rs—verify_ssl=Noneadded to the PyO3 constructor and passed through. Default behavior unchanged.11.0.0→11.1.0(Cargo.toml,pyproject.toml,Cargo.lock,uv.lock).docker-tests.yml— image tagsv11.0/v11.0.0→v11.1/v11.1.0(floatingv11unchanged).test_lookup_with_ssl_verification_disabled+ Pythontest_lookup_with_ssl_verification_disabled.Verification
cargo fmt --check,cargo clippy --all-targets --all-features -D warnings: cleancargo test --all-features: passmaturin develop+pytest test_cloudcheck.py: 16/16 passverify_ssl=False: passCloses #272.