Land fold exec on main (recover stranded stacked-PR commits) - #4
Merged
Conversation
There was no way to get a shell into a deployed machine to inspect it —
a major DX gap for an agent runtime. This adds one-shot command exec.
- Runtime gains Exec; the docker runtime implements it via `docker exec`
(stdin forwarded, exit code surfaced). wasm/microVM/firecracker return
ErrExecUnsupported (no shell / vsock-or-ssh exec is roadmap).
- The host agent admin API serves POST /v1/machines/{id}/exec alongside
the existing logs route, bounded by a per-command timeout.
- Control resolves the target machine (named, or the first running one),
proxies to the host agent, and records an exec event + audit entry.
- API exposes POST /v1/apps/{app}/exec gated by the deploy scope.
- `fold exec [-a app] [--machine id] -- <cmd>` prints combined output,
forwards piped stdin, and exits with the command's exit code.
Interactive TTY sessions and long-lived streams (tail -f) are out of
scope for this first version (one-shot, bounded by --timeout).
Tests: machine-target resolution (auto-pick running, reject unscheduled/
unknown), exec scope+validation (viewer 403, missing cmd 400, no running
machine 502), and the wasm-unsupported contract. Verified end-to-end with
a local deploy: output, env/hostname, stdin pipe, and exit-code 7.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #3 (
fold exec) was stacked on PR #2's branch (feat/central-machine-logs). When #2 merged tomainand its branch was deleted, #3 was then merged into that stacked base branch rather than intomain. GitHub marks #3 as "merged", but its commits never reachedmain—mainhas nofold exec.This re-lands the exec work by cherry-picking the original commit (
d526457) ontomain. No code changes versus what #3 already reviewed and approved; it applies cleanly on top of the merged logs work.Verification
git cherry-pickapplied with no conflictsgofmt -lclean ·go vet ./...clean ·go test ./...all passfold execroute/command present againNote for future stacked PRs
Merge the base PR first, then retarget the stacked PR to
mainbefore merging it — otherwise its merge lands on a soon-to-be-deleted base and is lost frommain.🤖 Generated with Claude Code