fix: update imports for environments v0.7.5's package reorg - #97
Merged
Conversation
Bumps github.com/blanketops/environments v0.7.2 -> v0.7.5, which
restructured most of the library from flat per-domain files into
subpackages:
- core -> core/{cache,command,conditions,
domain,engine,events,predicates,
registry}
- resolution/<domain> -> resolution/<domain>/resolve
- pkg/secrets/{git,registry,
github} -> one subpackage per consumer
(e.g. pkg/secrets/git/build,
pkg/secrets/git/deployment,
pkg/secrets/git/fluxcd, ...)
- pkg/apis/packages/intent -> pkg/intent/package
- pkg/apis/deployment/api's
NewRuntimeProvider,
NewReconciliationExecutor -> pkg/apis/deployment/strategy,
pkg/apis/deployment/reconcile
- pkg/apis/deployment/
application.NewIntentBuilder -> pkg/intent/deployment
Also two real (non-mechanical) API changes along the way:
- github.NewGitHubProviderSecretReconciler gained a storeKind
parameter, matching every other reconciler's signature.
- GitHubEvent resolution dropped its proto-style Contract wrapper
(ToGitHubEventContract().GetEventId() etc.) in favor of plain
string fields directly on ResolvedGitHubEventSpec (EventID,
EventType, Ref, CommitSHA) — call sites in the build-observer and
githubevent-observer updated accordingly.
Where a subpackage name collided with an existing import in the same
file (core/events vs k8s.io/client-go/tools/events; the new
pkg/intent/deployment package named `deployment` vs this repo's own
internal/mediators/deployment import), the new import is aliased
rather than renaming the existing one, to minimize the diff.
go build ./..., go vet ./..., and gofmt all pass clean. No test files
exist in this repo to run.
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
github.com/blanketops/environmentsv0.7.2 → v0.7.5 and updates every import path affected by that release's package reorg (flat per-domain files → subpackages undercore/,resolution/<domain>/resolve,pkg/secrets/{git,registry,github}/<consumer>,pkg/intent/{package,deployment}).Why
environmentsv0.7.5 restructured most of the library into subpackages (see commit message for the full old→new mapping). Without this,environments-controllerdoesn't compile at all against v0.7.5.Two real (non-mechanical) API changes came along with the reorg and needed actual code fixes, not just import-path updates:
github.NewGitHubProviderSecretReconcilergained astoreKindparameter, matching every other reconciler's signature.GitHubEventresolution dropped its proto-styleContractwrapper (ToGitHubEventContract().GetEventId()etc.) for plain string fields directly onResolvedGitHubEventSpec(EventID,EventType,Ref,CommitSHA) — updated the build-observer and githubevent-observer call sites accordingly.Domain
environmentseventssourcesnetworkscommonAPI impact
Checklist
go build ./...,go vet ./...,gofmt -lall pass cleanmage verify— no mage target in this repo; substituted the abovebuf breaking— not applicable, no proto contract changes herepanic()calls addedgen/go/blanketops/...contract types touchedNotes for reviewer
No test files exist in this repo currently (tracked as a follow-up — coverage work is starting next, scoped to domains/mediators/cache, not the controller-runtime wiring layer).