Add sandbox retry logic - #196
Open
mendral-app[bot] wants to merge 1 commit into
Open
Conversation
Add _request_with_retry method to SandboxAction (async) and SyncSandboxAction (sync) that detects retryable API errors (e.g. WORKLOAD_UNAVAILABLE during cold starts) and automatically retries with exponential backoff: 500ms → 30s, ~60s total budget. All sandbox HTTP operations (process exec/get/list/stop/kill/logs, filesystem mkdir/write/read/rm/ls/find/grep, multipart uploads) now use this retry wrapper, eliminating user-facing errors when sandboxes are scaling from zero.
Member
|
This is relevant to the dominant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKLOAD_UNAVAILABLE), respecting 500ms→30s backoff and ~60s total budgetResponseErrorduring sandbox cold starts by automatically retrying instead of failing immediatelyDetails
The sandbox API returns
{ "error": { "code": "WORKLOAD_UNAVAILABLE", "retryable": true } }when a sandbox is scaling from zero. Previously, all sandbox operations raisedResponseErrorimmediately on any non-2xx response without checking theretryablefield.This PR adds a
_request_with_retrymethod to bothSandboxAction(async) andSyncSandboxAction(sync) that:retryable: trueAll sandbox data-plane operations (process, filesystem, multipart uploads) now use this method.
Resolves: https://app.mendral.com/insights/01KXVWJ0B6X2PV2MJZSNSFDVTY
Note
Created by Mendral. Tag @mendral-app with feedback or questions.