fix: resolve portal render timeout for nested floating content - #120
Merged
Conversation
Move NotifyPortalRendered before the _pendingRerender check in PortalHost.OnAfterRenderAsync. Nested portals (e.g., Combobox inside Dialog) trigger RefreshPortal during PortalHost's render cycle, setting _pendingRerender. The early return skipped NotifyPortalRendered, forcing FloatingPortal to wait an extra render cycle and exceed its 500ms timeout.
PopoverContent gains Strategy and ZIndex parameters so Combobox and MultiSelect dropdowns escape dialog stacking contexts. Updated demos with nested portal regression tests and expanded changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotifyPortalRenderedbefore the_pendingRerendercheck inPortalHost.OnAfterRenderAsync, so portals rendered in the current cycle are notified immediately rather than being skipped by the early returnRoot Cause
When a Combobox opens inside a Dialog, the nested
FloatingPortalregisters withPortalService. During PortalHost's re-render, the nested portal'sOnParametersSetcallsRefreshPortal(), setting_pendingRerender = true. The_pendingRerendercheck then returned early, skippingNotifyPortalRendered— forcingFloatingPortalto wait an extra render cycle that exceeded the 500ms timeout.Close #119 #118